fix: CLI validate now accepts YAML/TOML specs - #3
Merged
Conversation
The `vnvspec validate` command was hardcoded to use `json.loads()`, causing it to fail on YAML and TOML spec files with a misleading "Spec validation error" message. This was inconsistent with the programmatic API which already supported all three formats. Changes: - Add `Spec.from_file(path)` classmethod that auto-detects format by file extension (.yaml/.yml, .json, .toml) - Rewrite CLI validate to use `Spec.from_file()` instead of raw `json.loads()` - Add REQ-SELF-CLI-002 and REQ-SELF-IO-002 to self-spec - Add 10 new tests covering from_file and CLI multi-format support
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vnvspec validatewas hardcoded tojson.loads(), failing on YAML/TOML spec files with a misleading errorSpec.from_file(path)that auto-detects format by extension, and rewired CLI validate to use itSpec.from_file(), 5 for CLI validate multi-format)Test plan
vnvspec validate .vnvspec/self-spec.yamlworks correctly