[T613] Expose directory evidence for existence checks#280
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0562606e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| boolean asksExistence = lower.contains("exists") | ||
| || lower.contains("exist") | ||
| || lower.contains("present") | ||
| || lower.contains("is there") | ||
| || lower.contains("are there"); |
There was a problem hiding this comment.
Keep “present” from widening ordinary read prompts
For prompts like “Present README.md as bullet points,” TaskContractResolver extracts README.md as an expected target and this substring check treats the imperative verb “present” as an existence question. That changes the surface from the narrow expected target read path to talos.list_dir + talos.read_file, allowing directory enumeration even though the user only asked to format/read a named file. Please restrict this to status phrasing such as is/are present rather than any occurrence of present.
Useful? React with 👍 / 👎.
Summary
talos.list_dirplustalos.read_filefor existence/path-status prompts while keeping mutation and command tools hiddenRead filepromptsVerification
ToolSurfacePlannerTest.fileExistenceQuestionsExposeDirectoryAndFileReadEvidenceToolsfailed before implementation./gradlew.bat test --tests "dev.talos.runtime.toolcall.ToolSurfacePlannerTest" --no-daemon./gradlew.bat test --tests "dev.talos.runtime.toolcall.*" --no-daemongit diff --check./gradlew.bat validateArchitectureBoundaries --no-daemon./gradlew.bat check --no-daemon