[T618] Fix scoped static-web verification#284
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9bb70f8fab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| List<String> formProblems = StaticWebStructureVerifier.calculatorFormProblems( | ||
| contract.originalUserRequest(), selectors.html()); | ||
| problems.addAll(formProblems); | ||
| staticWebProblems.addAll(formProblems); |
There was a problem hiding this comment.
Keep calculator form failures blocking for scoped JS fixes
When the turn is scoped to a single JavaScript target, these calculator/form structure failures are now passed through StaticWebProblemScope. That scope only treats JavaScript-named problems as blocking, so messages such as Calculator/form task is missing a form or input container become contextual facts and the verifier can pass a request like “fix scripts.js so the BMI calculator works” even though the HTML lacks required inputs/buttons/results. These form checks were previously added directly to problems, so this weakens functional-web verification for scoped JS repairs.
Useful? React with 👍 / 👎.
Summary
Verification
./gradlew.bat test --tests "dev.talos.runtime.verification.StaticTaskVerifierTest.scopedCssRewriteDoesNotFailOnUnrelatedMissingJavaScriptLink" --tests "dev.talos.runtime.verification.StaticTaskVerifierTest.scopedCssRewriteStillFailsWhenCssTargetIsEmpty" --tests "dev.talos.runtime.verification.StaticTaskVerifierTest.scopedCssRewriteStillFailsWhenHtmlDoesNotLinkCssTarget" --tests "dev.talos.runtime.verification.StaticTaskVerifierTest.scopedJavaScriptRewriteStillFailsWhenHtmlDoesNotLinkJavaScriptTarget" --tests "dev.talos.runtime.verification.StaticTaskVerifierTest.fullStaticWebCreateStillFailsWhenHtmlDoesNotLinkJavaScriptTarget" --tests "dev.talos.cli.modes.ExecutionOutcomeTest.postApplyScopedCssVerificationDoesNotOverclaimFullWebCoherence" --no-daemon./gradlew.bat test --tests "dev.talos.runtime.verification.StaticTaskVerifierTest" --tests "dev.talos.cli.modes.ExecutionOutcomeTest" --no-daemon./gradlew.bat test --tests "dev.talos.runtime.toolcall.RolefulIntentRecoveryRegressionTest" --no-daemon./gradlew.bat test --tests "dev.talos.runtime.outcome.EvidenceContainmentAnswerGuardTest" --tests "dev.talos.cli.modes.ReadEvidenceHandoffTest" --no-daemongit diff --check./gradlew.bat validateArchitectureBoundaries --no-daemon./gradlew.bat check --no-daemon