[T619] Render grounded path-existence answers#285
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 265fb3205f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private static String status(Path root, String target) { | ||
| Path resolved = resolve(root, target); | ||
| if (resolved == null) return "outside workspace"; | ||
| return Files.exists(resolved) ? "exists" : "not found"; |
There was a problem hiding this comment.
Use no-follow checks when verifying path existence
In workspaces containing a broken symlink, this reports <link>: not found even though the path entry itself exists and talos.list_dir evidence would show it. Files.exists(resolved) follows the symlink target by default, so a broken link is treated the same as an absent path; path-existence answers should check the directory entry itself, e.g. with LinkOption.NOFOLLOW_LINKS or an explicit symbolic-link check.
Useful? React with 👍 / 👎.
Summary
PATH_EXISTENCE_EVIDENCE_REQUIREDis already satisfied.Verification
./gradlew.bat test --tests "dev.talos.cli.modes.ExecutionOutcomeTest.pathExistenceAnswerPrependsExactStatusWhenListDirEvidenceIsSatisfied" --tests "dev.talos.cli.modes.ExecutionOutcomeTest.pathExistenceAnswerWithOnlyIrrelevantReadEvidenceRemainsContained" --no-daemon./gradlew.bat test --tests "dev.talos.runtime.outcome.EvidenceContainmentAnswerGuardTest" --tests "dev.talos.cli.modes.ReadEvidenceHandoffTest" --no-daemon./gradlew.bat test --tests "dev.talos.runtime.toolcall.RolefulIntentRecoveryRegressionTest" --tests "dev.talos.runtime.toolcall.ToolSurfacePlannerTest" --no-daemon./gradlew.bat test --tests "dev.talos.cli.modes.ExecutionOutcomeTest" --no-daemongit diff --check./gradlew.bat validateArchitectureBoundaries --no-daemon./gradlew.bat check --no-daemon