Skip to content

[T619] Render grounded path-existence answers#285

Merged
ai21z merged 1 commit into
v0.9.0-beta-devfrom
T619
May 31, 2026
Merged

[T619] Render grounded path-existence answers#285
ai21z merged 1 commit into
v0.9.0-beta-devfrom
T619

Conversation

@ai21z

@ai21z ai21z commented May 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add deterministic path-existence status rendering once PATH_EXISTENCE_EVIDENCE_REQUIRED is already satisfied.
  • Preserve containment for irrelevant or missing evidence.
  • Keep the existing read-only path-existence tool surface unchanged.

Verification

  • RED observed first: exact-status rendering test failed before implementation while irrelevant-evidence containment remained guarded.
  • ./gradlew.bat test --tests "dev.talos.cli.modes.ExecutionOutcomeTest.pathExistenceAnswerPrependsExactStatusWhenListDirEvidenceIsSatisfied" --tests "dev.talos.cli.modes.ExecutionOutcomeTest.pathExistenceAnswerWithOnlyIrrelevantReadEvidenceRemainsContained" --no-daemon
  • ./gradlew.bat test --tests "dev.talos.runtime.outcome.EvidenceContainmentAnswerGuardTest" --tests "dev.talos.cli.modes.ReadEvidenceHandoffTest" --no-daemon
  • ./gradlew.bat test --tests "dev.talos.runtime.toolcall.RolefulIntentRecoveryRegressionTest" --tests "dev.talos.runtime.toolcall.ToolSurfacePlannerTest" --no-daemon
  • ./gradlew.bat test --tests "dev.talos.cli.modes.ExecutionOutcomeTest" --no-daemon
  • git diff --check
  • ./gradlew.bat validateArchitectureBoundaries --no-daemon
  • ./gradlew.bat check --no-daemon

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 265fb3205f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

private static String status(Path root, String target) {
Path resolved = resolve(root, target);
if (resolved == null) return "outside workspace";
return Files.exists(resolved) ? "exists" : "not found";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use no-follow checks when verifying path existence

In workspaces containing a broken symlink, this reports <link>: not found even though the path entry itself exists and talos.list_dir evidence would show it. Files.exists(resolved) follows the symlink target by default, so a broken link is treated the same as an absent path; path-existence answers should check the directory entry itself, e.g. with LinkOption.NOFOLLOW_LINKS or an explicit symbolic-link check.

Useful? React with 👍 / 👎.

@ai21z ai21z merged commit a453e3b into v0.9.0-beta-dev May 31, 2026
1 check passed
@ai21z ai21z deleted the T619 branch May 31, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant