Skip to content

[T621] Ignore CSS comments in selector extraction#286

Merged
ai21z merged 1 commit into
v0.9.0-beta-devfrom
T621
May 31, 2026
Merged

[T621] Ignore CSS comments in selector extraction#286
ai21z merged 1 commit into
v0.9.0-beta-devfrom
T621

Conversation

@ai21z

@ai21z ai21z commented May 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Strip CSS block comments before static selector extraction.
  • Add a regression test for the T620 live-audit false failure where styles.css in a stylesheet header comment was interpreted as missing selector .css.
  • Preserve existing selector/linkage behavior; real missing selector diagnostics remain covered by the existing verifier suites.

Root Cause

StaticWebSelectorAnalyzer scanned CSS selector preludes without removing block comments. A normal header comment such as /* styles.css */ could be captured before the first { and then parsed as class selector .css, causing a false static verification failure after an otherwise valid styles.css write.

Verification

  • RED: StaticWebSelectorAnalyzerTest.cssFileNameInCommentIsNotTreatedAsMissingClassSelector failed before implementation with the .css false-positive.
  • GREEN: same focused test passed after stripping CSS block comments.
  • ./gradlew.bat test --tests "dev.talos.runtime.verification.StaticWebSelectorAnalyzerTest" --tests "dev.talos.runtime.verification.StaticTaskVerifierTest" --no-daemon
  • ./gradlew.bat test --tests "dev.talos.cli.modes.ExecutionOutcomeTest" --no-daemon
  • git diff --check (CRLF warnings only)
  • ./gradlew.bat validateArchitectureBoundaries --no-daemon
  • ./gradlew.bat check --no-daemon

@ai21z ai21z merged commit 0404b39 into v0.9.0-beta-dev May 31, 2026
1 check passed
@ai21z ai21z deleted the T621 branch May 31, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant