Feature/Project memory and symbol retrieval hardening#287
Conversation
Adds visible project memory, compaction accounting, structure-first symbol retrieval, symbol sidecar recovery, and ticket-track updates for T708-T716.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b73301fc7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| String text = parseIndexableText(rootPath, p); | ||
| stats.addParseTime(System.currentTimeMillis() - parseStart); | ||
| stats.incrementFilesEmbedded(); | ||
| refreshedSymbolsByPath.put(rel, SymbolExtractor.extract(rel, text)); |
There was a problem hiding this comment.
When a user runs the normal /reindex or talos index path after upgrading from an index that has Lucene chunks but no talos-symbols.json, unchanged files hit the existing store.isUpToDate(...) early return before this map is populated. Because existingSymbolsByPath is empty in that migration case, writeMergedSymbolIndex(...) later writes an empty sidecar even though all code files are already indexed, so exact symbol retrieval stays disabled until the user knows to force a full reindex.
Useful? React with 👍 / 👎.
| "\\b(?:(?:public|protected|private|static|final|synchronized|abstract|native|default|strictfp)\\s+)+" | ||
| + "[A-Za-z_$][A-Za-z0-9_$<>\\[\\],.?\\s]*\\s+([A-Za-z_$][A-Za-z0-9_$]*)\\s*\\([^;{}]*\\)"); |
There was a problem hiding this comment.
This method pattern requires at least one modifier before the return type, so package-private declarations such as String buildSetlist() or void helper() are never added to the symbol sidecar. In Java workspaces that use package-private helpers, exact queries for those method names will not get the new structure-first symbol evidence and will silently fall back to less precise snippet retrieval.
Useful? React with 👍 / 👎.
1 participant
Summary
Implements the T708-T716 batch:
Validation
git diff --cached --check.\gradlew.bat check --no-daemonBoth passed before commit. Full
checkalso passed after the final T716 cleanup.Notes
This is an inner-loop infrastructure batch, not a release candidate. No version bump or live audit is included.