T717 harden symbol extraction migration#288
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 608dd76752
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "^\\s*(?:(?:public|protected|private|static|final|synchronized|abstract|native|default|strictfp)\\s+)*" | ||
| + "(?:<[^;{}()]+>\\s+)?" | ||
| + "[A-Za-z_$][A-Za-z0-9_$<>\\[\\],.?]*(?:\\s+[A-Za-z_$][A-Za-z0-9_$<>\\[\\],.?]*)*\\s+" | ||
| + "([A-Za-z_$][A-Za-z0-9_$]*)\\s*\\([^;{}]*\\)\\s*(?:\\{|;|$)"); |
There was a problem hiding this comment.
When a Java method declaration includes a throws clause, this hardened pattern no longer matches because it requires the text immediately after ) to be {, ;, or end-of-line. Common declarations such as public void load() throws IOException { and interface methods like void close() throws Exception; therefore disappear from the symbol sidecar, which weakens code-navigation/retrieval evidence for ordinary Java projects even though these methods were previously picked up by the looser matcher.
Useful? React with 👍 / 👎.
1 participant
No description provided.