Remove unused TLS material loader and update tests (issue #345) - #346
Merged
Conversation
This commit is for issue #345: Remove the unused TLS material loader wrapper and update tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 89.11% 89.10% -0.01%
==========================================
Files 7 7
Lines 3270 3269 -1
==========================================
- Hits 2914 2913 -1
Misses 356 356 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danbi2990
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #345
Summary
This PR removes an unused thin wrapper function,
load_tls_material,from src/main.rs that triggered a dead-code warning on the default
cargo checkpath. Tests and documentation that previously referencedthat wrapper were updated to use
load_tls_material_with_bytesdirectly and discard the raw TLS bytes where only parsed
Certsarerequired.
What changed
load_tls_materialfrom src/main.rs.load_tls_material_with_bytesto remove referencesto the removed wrapper.
src/subscribe/tests.rs) to call
load_tls_material_with_bytesandignore the raw bytes when appropriate.
parsed and validated before being published to reload paths.
Files touched (high level)
Validation performed
(passes)
Notes
This is an internal cleanup with no user-visible behaviour changes.
When reviewing, please note PR #303 (cooperative shutdown work) so the
maintainer can ensure no overlap with concurrent changes.
Issue: #345