Render a declared limit through the manifest read path (#78) - #82
Merged
Conversation
The bump to manifest format version 5 was cut so a producer's manifest could carry `limit_nofile`, but nothing asserted that end: the wire form was exercised for the two refusals and for the floor version that emits no directive, while the positive case reached the renderer only from a hand-built template. A spec decoded from a producer's bytes now renders `LimitNOFILE=` too, mirroring the test the previous bump left behind. Part of #78
Contributor
Author
|
[Reviewer Round 1] Approved — no findings. The new test in src/manifest.rs genuinely exercises the missing producer-wire-form path: it parses a v5 manifest containing It complements the existing renderer placement and floor-compatibility tests without broadening scope. PR #82’s |
Contributor
Author
|
[Review Verdict Round 1: APPROVED] |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bump to manifest format version 5 was cut so a producer's manifest could carry
limit_nofile, but nothing asserted that end. The wire form was exercised for the two refusals and for the floor version that emits no directive; the positive case reached the renderer only from a hand-built template, so the read path this bump exists for was never driven end to end.This adds
a_manifest_at_the_current_version_renders_a_declared_descriptor_limitinsrc/manifest.rs: a manifest atMANIFEST_FORMAT_VERSIONdeclaringlimit_nofileparses, the decoded spec carries the value, and the renderer emitsLimitNOFILE=8000on the line afterRestartSec=, asserted against the full unit text. It mirrors the test the previous format bump left behind for the manager endpoint.No production code changes.
Part of #78
Not addressed
Everything else the issue asked for — the
limit_nofilefield onUnitTemplate, the twoModuleSpecErrorvariants rejectingSome(0)andSome(u64::MAX), theLimitNOFILE=emission betweenRestartSec=and the sandbox booleans, the producer/ceiling version bump with the floor held still, the rewrittencheck_format_versiondoc comment, and the rest of the test plan — already landed onmainin #80, which closed the issue. This branch carries only the one read-path assertion that work left uncovered, so nothing in the issue is outstanding once it merges.Test plan
cargo fmt -- --check --config group_imports=StdExternalCrateis cleancargo clippy --all-targets -- -D warningsandcargo clippy --all-targets --features test-support -- -D warningsare cleancargo testandcargo test --features test-supportpassMANIFEST_FORMAT_VERSIONdeclaringlimit_nofileparses, and the decodedUnitTemplatecarries the valueLimitNOFILE=8000in[Service]on the line afterRestartSec=and before the[Install]sectionMIN_MANIFEST_FORMAT_VERSIONrenders noLimitline