Track the current Biome release

.github/workflows/ci.yml

@@ -34,7 +34,7 @@ jobs:
       - name: Setup Biome CLI
         uses: biomejs/setup-biome@v2
         with:
-          version: 2.4.9
+          version: latest
 
       - name: Run Biome
         run: biome ci --error-on-warnings .

biome.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "https://biomejs.dev/schemas/2.4.9/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.5.7/schema.json",
   "vcs": {
     "enabled": true,
     "clientKind": "git",
@@ -35,7 +35,7 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true,
+      "preset": "recommended",
       "suspicious": {
         "noUnknownAtRules": "off"
       }

scripts/backfill-review-request-requested-at.ts

@@ -260,7 +260,7 @@ async function fetchReviewRequestsWithEvents(
   const latestEventByReviewer = new Map<string, string>(); // reviewerId -> createdAt
   for (const event of events) {
     const reviewer = event.requestedReviewer;
-    if (!reviewer || reviewer.__typename !== "User") {
+    if (reviewer?.__typename !== "User") {
       continue;
     }
     const existing = latestEventByReviewer.get(reviewer.id);
@@ -275,7 +275,7 @@ async function fetchReviewRequestsWithEvents(
 
   for (const node of reviewRequestNodes) {
     const reviewer = node.requestedReviewer;
-    if (!reviewer || reviewer.__typename !== "User") {
+    if (reviewer?.__typename !== "User") {
       continue;
     }
     const createdAt = latestEventByReviewer.get(reviewer.id) ?? null;

src/app/api/activity/[id]/project-fields/route.ts

@@ -165,7 +165,7 @@ function sanitizePayloadValue(key: ProjectFieldKey, raw: unknown) {
 
 async function resolveIssueItem(id: string) {
   const detail = await getActivityItemDetail(id);
-  if (!detail || detail.item.type !== "issue") {
+  if (detail?.item.type !== "issue") {
     return null;
   }
   return detail;

src/app/api/activity/[id]/status/route.ts

@@ -30,7 +30,7 @@ function isIssueProjectStatus(value: unknown): value is IssueProjectStatus {
 async function resolveIssueItem(id: string) {
   await ensureSchema();
   const detail = await getActivityItemDetail(id);
-  if (!detail || detail.item.type !== "issue") {
+  if (detail?.item.type !== "issue") {
     return null;
   }
   return detail;

src/lib/dashboard/analytics.ts

@@ -96,16 +96,18 @@ export async function getDashboardAnalytics(
   const timeZone = userTimeSettings.timezone;
   const dateTimeFormat = userTimeSettings.dateTimeFormat;
   const weekStart: WeekStart = userTimeSettings.weekStart;
+  const rawExcludedUserIds = config?.excluded_user_ids;
   const excludedUserIds = new Set<string>(
-    Array.isArray(config?.excluded_user_ids)
-      ? (config?.excluded_user_ids as string[]).filter(
+    Array.isArray(rawExcludedUserIds)
+      ? (rawExcludedUserIds as string[]).filter(
           (id) => typeof id === "string" && id.trim().length > 0,
         )
       : [],
   );
+  const rawExcludedRepositoryIds = config?.excluded_repository_ids;
   const excludedRepositoryIds = new Set<string>(
-    Array.isArray(config?.excluded_repository_ids)
-      ? (config?.excluded_repository_ids as string[]).filter(
+    Array.isArray(rawExcludedRepositoryIds)
+      ? (rawExcludedRepositoryIds as string[]).filter(
           (id) => typeof id === "string" && id.trim().length > 0,
         )
       : [],

src/lib/dashboard/attention.ts

@@ -257,16 +257,18 @@ export async function getAttentionInsights(options?: {
   const organizationHolidaySet = await loadCombinedHolidaySet(
     organizationHolidayCodes,
   );
+  const rawExcludedUserIds = config?.excluded_user_ids;
   const excludedUserIds = new Set<string>(
-    Array.isArray(config?.excluded_user_ids)
-      ? (config?.excluded_user_ids as string[]).filter(
+    Array.isArray(rawExcludedUserIds)
+      ? (rawExcludedUserIds as string[]).filter(
           (id) => typeof id === "string" && id.trim().length > 0,
         )
       : [],
   );
+  const rawExcludedRepositoryIds = config?.excluded_repository_ids;
   const excludedRepositoryIds = new Set<string>(
-    Array.isArray(config?.excluded_repository_ids)
-      ? (config?.excluded_repository_ids as string[]).filter(
+    Array.isArray(rawExcludedRepositoryIds)
+      ? (rawExcludedRepositoryIds as string[]).filter(
           (id) => typeof id === "string" && id.trim().length > 0,
         )
       : [],

src/lib/db/schema.ts

@@ -821,7 +821,7 @@ let ensurePromise: Promise<void> | null = null;
 
 function isPublicSchemaPermissionError(error: unknown) {
   const dbError = error as DatabaseError | null;
-  if (!dbError || dbError.code !== "42501") {
+  if (dbError?.code !== "42501") {
     return false;
   }
 

src/lib/github/collectors/issues.ts

@@ -413,7 +413,7 @@ async function fetchDiscussionCommentRepliesConnection(
     },
   );
   const node = data.node;
-  if (!node || node.__typename !== "DiscussionComment") {
+  if (node?.__typename !== "DiscussionComment") {
     return null;
   }
   return node.replies ?? null;

src/lib/github/collectors/pull-requests.ts

@@ -80,7 +80,7 @@ async function syncReviewRequestsSnapshot(
 
   const latestEventByReviewer = new Map<string, string>(); // reviewerId -> createdAt
   for (const node of events) {
-    if (!node || node.__typename !== "ReviewRequestedEvent") {
+    if (node?.__typename !== "ReviewRequestedEvent") {
       continue;
     }
     const reviewer = node.requestedReviewer;