Fix issue #866: Implement the atomic single-PR change: swap ZZ/XX meanings, add the placeholder-swap - #868
Open
octoaide[bot] wants to merge 2 commits into
Open
Fix issue #866: Implement the atomic single-PR change: swap ZZ/XX meanings, add the placeholder-swap#868octoaide[bot] wants to merge 2 commits into
octoaide[bot] wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
+ Coverage 84.58% 84.74% +0.16%
==========================================
Files 92 92
Lines 37105 37524 +419
==========================================
+ Hits 31385 31801 +416
- Misses 5720 5723 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sophie-cluml
requested changes
Sep 4, 2026
|
|
||
| /// Last default-column-family key durably processed by the placeholder swap. | ||
| const COUNTRY_CODE_SWAP_CHECKPOINT_KEY: &[u8] = | ||
| b"migration/0.47.0-alpha.3/country-code-placeholder-swap/checkpoint"; |
Contributor
There was a problem hiding this comment.
Suggested change
| b"migration/0.47.0-alpha.3/country-code-placeholder-swap/checkpoint"; | |
| b"migration/0.47.0/country-code-placeholder-swap/checkpoint"; |
The migration logic looks sound. My two suggestions make the checkpoint and completion keys stable across the 0.47 prerelease chain. Later alphas extend the same migration, so tying these keys to alpha.3 risks renaming them and reapplying the non-idempotent swap. Please use the final 0.47.0 format namespace before merge.
|
|
||
| /// Durable marker preventing the placeholder swap from being applied twice. | ||
| const COUNTRY_CODE_SWAP_COMPLETED_KEY: &[u8] = | ||
| b"migration/0.47.0-alpha.3/country-code-placeholder-swap/completed"; |
Contributor
There was a problem hiding this comment.
Suggested change
| b"migration/0.47.0-alpha.3/country-code-placeholder-swap/completed"; | |
| b"migration/0.47.0/country-code-placeholder-swap/completed"; |
Use the final 0.47.0 namespace for checkpoint and completion keys to preserve idempotence across prerelease updates.
Contributor
Author
|
Implemented the reviewer’s checkpoint-key feedback in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the atomic single-PR change: swap ZZ/XX meanings, add the placeholder-swap migration and retry-safe checkpointing, allow placeholder filtering, and update docs/tests. Create a draft branch/PR containing code, tests, and docs per the issue plan.
Changed files
CHANGELOG.mdCargo.tomlREADME.mdsrc/event.rssrc/event/bootp.rssrc/event/common.rssrc/event/conn.rssrc/event/dcerpc.rssrc/event/dhcp.rssrc/event/dns.rssrc/event/ftp.rssrc/event/http.rssrc/event/kerberos.rssrc/event/ldap.rssrc/event/malformed_dns.rssrc/event/mqtt.rssrc/event/network.rssrc/event/nfs.rssrc/event/ntlm.rssrc/event/radius.rssrc/event/rdp.rssrc/event/smb.rssrc/event/smtp.rssrc/event/ssh.rssrc/event/stored_timestamp_contract.rssrc/event/tls.rssrc/event/tor.rssrc/event/unusual_destination_pattern.rssrc/lib.rssrc/migration.rssrc/migration/migration_structures.rssrc/util.rsCloses #866
This pull request was automatically created by octoaide.