Rename detection event time fields in GraphQL (Closes #874) - #909
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
+ Coverage 85.29% 85.33% +0.04%
==========================================
Files 77 77
Lines 31067 31160 +93
==========================================
+ Hits 26498 26591 +93
Misses 4569 4569 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kimhanbeom
requested changes
Aug 20, 2026
kimhanbeom
force-pushed
the
octoaide/issue-874-2026-08-12T15-39-12
branch
from
August 21, 2026 05:04
e1adba2 to
6ba3b31
Compare
kimhanbeom
force-pushed
the
octoaide/issue-874-2026-08-12T15-39-12
branch
from
August 26, 2026 04:36
6ba3b31 to
dc4ceda
Compare
kimhanbeom
approved these changes
Aug 26, 2026
sophie-cluml
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the breaking GraphQL schema rename for ambiguous
detection event time fields as described in #874. It pins the
review-database dependency to commit 644db00 and updates schema
resolvers, field descriptions, fixtures, and tests to match the new
field names.
What changed
Affected event types: PortScan, MultiHostPortScan, ExternalDdos,
FtpBruteForce, LdapBruteForce, RdpBruteForce, RepeatedHttpSessions
Files touched (high level)
unusual_destination_pattern, conn, etc.)
Breaking change
This is a breaking GraphQL schema change: clients that use the old
startTime/endTime fields must be updated to the new field names.
Testing notes / merge instructions
Local formatting, lint, and unit tests passed. I could not regenerate
Cargo.lock locally because GitHub DNS access prevented Cargo from
fetching the pinned review-database commit; as a result the lockfile was
not updated here. Please run
cargo update -p review-database(orallow CI to fetch and update the lockfile) before merging so the
lockfile contains the new reference.
Closes #874