Skip to content

Automation of Windows' Tauri builds#7

Open
felix91gr wants to merge 16 commits into
aichingm:mainfrom
felix91gr:main
Open

Automation of Windows' Tauri builds#7
felix91gr wants to merge 16 commits into
aichingm:mainfrom
felix91gr:main

Conversation

@felix91gr

@felix91gr felix91gr commented Dec 7, 2023

Copy link
Copy Markdown

Heeey. I hope these can be squashed together or something, because I needed to push a ton of commits in order to test the GA system.

Added:

  • Github Actions' automation for both Linux and Windows
  • rsvg-convert is no longer required, I believe. At least not for the Tauri build
  • Added me as a contributor (I think)
  • Point release bump (1.1.1 now)
  • Documented a new space where the version number matters (lonewolf-tauri/src-tauri/tauri.conf.json:11)

To do before merging: (I'm opening this RN so that you can take a look and give feedback in the meantime)

  • Add the make command change you mentioned here Windows Compatibility #6 (comment)
  • Document how to build locally in Windows
  • Clarify the best way to trigger the GA build. Currently, it triggers a build as soon as any change is pushed to the main branch. If the version number present at the tauri.conf.json file already has build artifacts in the site, they are overwritten by the GA whenever it runs successfully.

Comment thread lonewolf-tauri/package-lock.json
@felix91gr

Copy link
Copy Markdown
Author

This is how the GA runs look: https://github.com/felix91gr/lonewolf/actions

And this is how the releases look: https://github.com/felix91gr/lonewolf/releases

@felix91gr

Copy link
Copy Markdown
Author

@aichingm I ping you here because I'm only 50% certain that you get pinged when I open a pull request XD and I worry you might not have seen this yet.

Anywho. Please tell me what you think of this :)

Of the 3 tasks remaining, the first 2 are on me. The third one is for you: how would you like for the GA to be triggered? There are many ways to trigger them, and I should be able to accommodate this one to whatever's most comfortable for you :3

@aichingm

Copy link
Copy Markdown
Owner

Thanks for the ping! I have seen this pr already but I didn't get to ceckt it oit yet. Initially I wanted to find time over the weekend but... Life happened.

I need to read up on GA to figure out what options there are to trigger the actions.

Comment thread Development.md
@aichingm

Copy link
Copy Markdown
Owner

@felix91gr I fixed the version stuff and squashed the commits down into one. Could you rebase your for to match this one https://github.com/aichingm/lonewolf/tree/github-actions-windows-build so that I can FF-merge this PR?

Also "pestered" is a little harsh wouldn't you say? I have no problem leaving it in, just checking 😆

description: "Helped automate builds and pestered Mario to figure out Windows compatibility together"

@aichingm

aichingm commented Dec 14, 2023

Copy link
Copy Markdown
Owner

Also there are two more things which would need fixing:

@aichingm

Copy link
Copy Markdown
Owner

Note that I removed the linux builds, since I don't want to support multiple linux packaging formats at the moment. Flatpaks are in my opinion the best why do cater to a variety of distributions.

@aichingm aichingm changed the title Automation of Linux and Windows' Tauri builds Automation of Windows' Tauri builds Dec 14, 2023
@felix91gr

Copy link
Copy Markdown
Author

@aichingm gah, I'm so sorry I vanished. I've been swamped with work Q.Q just got started at a new job and I have very little energy left after the week's done.

I hope I'm able to dedicate a day or two to this during this month. Sorry to ask you this, but what's left to do right now? So that I know whenever I'm back, what things I must focus on right away :)

@aichingm

Copy link
Copy Markdown
Owner

@felix91gr same here, I have to check again, if there is is still something to do. I will let you know!

@aichingm

Copy link
Copy Markdown
Owner

I think there is not much to do at the moment. I have a branch on github which would be needed to be merged. The question is should I just merge my branch and close this PR or do you want the changes to be associated to your PR then you would need to rebase you fork on this branch: https://github.com/aichingm/lonewolf/tree/github-actions-windows-build

@aichingm aichingm force-pushed the main branch 2 times, most recently from ec8409b to 445e091 Compare May 1, 2025 23:31
@aichingm aichingm force-pushed the main branch 2 times, most recently from c8dfea5 to 5d7e2c5 Compare May 9, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants