Skip to content

feat(action): add configurable no-adapter strictness - #73

Merged
limaronaldo merged 1 commit into
mainfrom
agent/action-strict-mode
Jul 24, 2026
Merged

feat(action): add configurable no-adapter strictness#73
limaronaldo merged 1 commit into
mainfrom
agent/action-strict-mode

Conversation

@limaronaldo

Copy link
Copy Markdown
Collaborator

Summary

  • add a strict GitHub Action input, defaulting to true
  • allow only explicit strict: false to make no-adapter discovery errors non-blocking
  • keep invalid configuration and other scan errors blocking
  • emit strict: true from generated CI workflows without changing the public Rust API
  • cover permissive, strict, and genuine-error behavior in the Action E2E matrix

Why

Repositories that intentionally scan mixed trees may have paths with no supported AgentShield adapter. They need an explicit opt-out for that discovery condition without accidentally suppressing real scanner failures.

Verification

  • cargo fmt --all --check
  • cargo check --workspace --all-targets --locked
  • cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
  • cargo test --workspace --all-targets --locked — 422 passed
  • no-default and individual feature checks
  • Action/workflow YAML parsing and actionlint
  • full docs/harness/bin/sensors.sh — green

@limaronaldo limaronaldo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic verdict: PASS

Review checklist:

  • strict defaults fail-closed
  • only explicit strict: false suppresses the no-adapter discovery condition
  • invalid configuration and other scan errors remain blocking
  • scanner exit code 2 remains exposed even when the action check is non-blocking
  • generated workflows retain safe strict: true behavior
  • no breaking change to the public Rust CiInstallOptions API
  • composite-action E2E covers permissive, strict, and genuine-error paths
  • docs match implemented semantics

No blocking findings in the remote patch. Merge remains gated on the new-head CI, especially both Action E2E platforms.

@limaronaldo
limaronaldo marked this pull request as ready for review July 24, 2026 15:25
@limaronaldo
limaronaldo merged commit 02e7316 into main Jul 24, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant