refactor(graph): split duckdb_graph module - #190
Merged
Conversation
|
Connected to Huly®: ENGRA-226 |
limaronaldo
commented
Jul 12, 2026
limaronaldo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Code review summary (review-only)
I reviewed PR #190 as-is.
Findings
- NIT (non-blocking):
TemporalGraphinternal fields were changed from private topub(crate)insrc/graph/duckdb_graph/types.rs.conn,has_pgq, andsqlite_pathare only needed by sibling modules after the split.- You can keep internals less exposed by using
pub(super)(as discussed in your notes) instead ofpub(crate), which also avoids unnecessary API-surface expansion.
Verification completed
cargo fmt --all -- --check✅cargo test -p engram-core --all-features graph::✅ (78 passed, 1680 filtered out)- PR checks for 190 are all passing in CI (
gh pr checks 190-> 16 passed, 0 failed).
No blocking defects found; this is a clean refactor if the visibility tweak above is acceptable to tighten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/graph/duckdb_graph.rsinto five focused modules:mod.rs,types.rs,lifecycle.rs,queries.rs,traversal.rs, andtests.rs.graph::duckdb_graphmodule surface unchanged viapub mod duckdb_graphinsrc/graph/mod.rs.pub(super)) only for internal shared state across the split files.Verification
cargo check -p engram-core --all-featurescargo test -p engram-core --all-features graph::(78 passed, 1680 filtered out)cargo fmt --allcargo clippy -p engram-core --all-features --all-targetscargo public-api -p engram-core --simplifiedThe public API diff changed vs baseline from 19908 to 20088; this appears to be pre-existing/other drift and is not tied to this refactor.