Skip to content

remove extra err check and add cache clean for tests #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidenfine merged 1 commit into from
Apr 13, 2026
Merged

remove extra err check and add cache clean for tests #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
build:
go build -o ./build/

clean:
go clean -testcache
test:
go test ./...

integration-test:
go test -tags=integration -v -timeout 60m ./...
go test -tags=integration -v -timeout 60m ./...
5 changes: 0 additions & 5 deletions foreman-builder/cmd/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,6 @@ func (u User) createOrbstackContainer(opts foremanbuilder.OrbOptions) error {
Packages: config.Packages,
}

// check for errors by doing ssh <container-name>@orb cat /var/log/cloud-init-output.log
if err != nil {
foremanbuilder.Logger.Errorf("Failed to get home directory: %v", err)
return err
}
confsDir := filepath.Join(u.dotFilePath, "confs")
if err := os.MkdirAll(confsDir, 0755); err != nil {
foremanbuilder.Logger.Errorf("Failed to create confs directory: %v", err)
Expand Down
Loading