Repository navigation
fix/feat: doc comments, AdminChanged event, exact-goal tests, verifier reassignment - #34
Merged
Merged
Conversation
sweetsoul21
self-requested a review
October 8, 2026 20:18
sweetsoul21
approved these changes
Oct 8, 2026
sweetsoul21
left a comment
Contributor
There was a problem hiding this comment.
Goood job @RaymondAbiola
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1, #2, #3, #4
Issue #1 — Doc comments on all public functions
///doc comments to everypub fnin the#[contractimpl]blockErrorvalues it can returnIssue #2 — AdminChanged event on set_admin
AdminChanged { old, new }struct toevents.rsset_adminnow emits the event so indexers can track admin transfersset_admin_emits_admin_changed_event,set_admin_updates_stored_adminIssue #3 — Exact-goal boundary donation tests
three_donors_reach_goal_exactly_fourth_fails: three donors hit goal exactly, fourth attempt returnsGoalExceededtwo_donors_reach_goal_exactly_campaign_fully_funded: verifies milestone can release when goal is exactly metIssue #4 — Verifier reassignment
reassign_verifier(campaign_id, new_verifier)callable by admin onlyVerifierReassigned { campaign_id, old_verifier, new_verifier }Also fixed (pre-existing breakage)
errors.rs(prevented compilation)pull_pledges, duplicate imports and double transfer inapprove_milestonetest_measure_resource_costs(deprecatedenv.budget()→env.cost_estimate().budget())test_exact_events_emitted(invalid SDK APIs) → replaced withtest_events_emittedTested
make test— 31 tests passmake lint— no warnings or errors