Serve recording guide as PNG with explicit dimensions - #2
Merged
Merged
Conversation
The guide still rendered corrupted on mobile after the previous fix. The asset on GitHub was byte-complete and valid VP8, so the visible damage was not the file: GitHub's image CDN serves by URL path and kept returning the old 600x750 asset at the same path, and WebP decoding in mobile webviews is not guaranteed. - Replace the asset with PNG (1122x1402, 256 colours, 576 KB) under a new filename, so the CDN cache cannot serve the old corrupt version. - Drop the WebP file entirely so no stale reference remains. - Use an <img> tag with explicit width/height (561x701, exact half) to reserve the correct box and prevent layout shift while the image loads on narrow screens.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1.
The asset on GitHub was already byte-complete and valid VP8, so the corruption still visible on mobile was not the file:
Changes:
<img>with explicitwidth="561" height="701"(exact half size) so the layout box is reserved and the guide cannot shift while loading on narrow screens.Verified: RIFF container of the served WebP was complete and valid; the new PNG was inspected visually — all four sections intact and legible.