Fix frontend validation readiness in worktrees - #449
Open
adriandemian wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
adriandemian
marked this pull request as ready for review
June 24, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend/package context, runs from the package directory, and uses the local Vitest binary rather than a root/global fallback.node_modulestrees do not count as ready just because the directory exists.User Impact
Frontend worktrees should now validate against the actual app package instead of accidentally treating the repository root as the execution context. That reduces false-ready installs, avoids running the wrong Vitest binary, and makes readiness failures surface before validation proceeds.
The metrics IPC change keeps workspace-count reporting consistent with the delivery-trend contract used by the UI and tests.
Technical Context
agents/ralphx-project-analyzer/shared/prompt.mdnow tells the analyzer to emitpath: "frontend"when the only Node package lives underfrontend/package.json, and it avoids passingvitest.config.tsas a test target.frontend_readinessmodule centralizes frontend-specific cwd selection, Vitest command sanitization, package-context detection, executable checks, and Node import probes forvitest/config,react,zod, and@tauri-apps/api.run_install_phaseandrun_validate_phasenow consult that readiness logic before skipping installs or starting validation, and they fail early when frontend dependencies are still incomplete.src-tauri/tests/metrics_commands.rswas updated to keep the IPC delivery-trend contract aligned with the workspace-count expectations.Risks / Follow-Ups
Generated by RalphX