Fix ideation PR generation and task detail crash - #538
Open
adriandemian wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
reefagent
force-pushed
the
fix/ideation-pr-generation-pr-description
branch
from
June 30, 2026 11:07
0df7335 to
6129517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viewModeobjects in both Kanban and Agents task panels to avoid context churn on identical rerenders.User Impact
Ideation merge tasks can draft PR descriptions again instead of failing with
FOREIGN KEY constraint failedbefore PR creation. The Merge Incomplete/task-detail surface also avoids the unstable context updates that can trip React's maximum update depth guard when the error boundary is shown.Technical Context
agent_conversation_workspaces.conversation_idreferenceschat_conversations(id). The PR describer previously generated a synthetic conversation id only for the workspace, which worked in memory tests but failed under SQLite. The new helper parent conversation is archived immediately so it stays out of normal project chat lists, then both workspace and conversation rows are removed after success or failure. If workspace creation itself fails, the synthetic parent is deleted before returning the error.The frontend fix memoizes the registry
TaskDetailViewModepassed intoTaskDetailContextProvider. A focused regression records the contextviewModereference across query-driven renders and explicit rerenders so this class of update loop cannot silently return.Risks / Follow-Ups
No expanded React component stack was available in local logs or the user report, so the UI fix targets the concrete instability on the reported Merge Incomplete/task-detail path. If a different component is also involved, the error boundary stack will still be needed for a follow-up.
Validation performed locally:
plan_pr_descriptionlib tests, including SQLite FK regression and cleanup assertions.git diff --check.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.