Debug PR #849 describer cross-project ticket leak

[adriandemian]

Summary

Fixes cross-project ticket link contamination in ClickUp reconciliation for agent workspaces. When a PR title was auto-normalized with a ticket prefix or after a base-update merge with a stale local base ref, RalphX would link conversations to tickets in unrelated projects.

Root causes:

1. PR title and body were accepted as link evidence, allowing RalphX's own normalizer output to self-validate the link it created (title-only contamination loop)
2. git log base..HEAD after a stale-base merge includes commits imported from the base itself, not just branch-authored commits (base-commit leak)

Fixes:

• New GitService::get_branch_authored_commits() — Uses git log --first-parent --not base origin/base to walk only the branch's own commit line, excluding commits imported by base-update merges. Tolerates missing origin/<base> via --ignore-missing.

• Evidence scoping in reconcile_clickup_pr_to_conversation() — PR title and body are now discovery-only; only workspace-owned signals (branch name, branch-authored commit subjects) can authorize a ticket link. Filters evidence before matching candidates.

• Reconciliation uses scoped commits — Replaced get_commits_between() with get_branch_authored_commits() for ticket candidate discovery.

• Regression tests — Three new tests verify title-only, body-only, and commit-subject evidence paths; two git-service tests verify the first-parent walk excludes imported commits and handles missing remote refs.

User Impact

Users will no longer see spurious cross-project ClickUp links created when running agent workspaces on stale base refs or when PR titles are auto-normalized with ticket prefixes.

Technical Context

ClickUp ticket linking in external PR reconciliation must trust only durable workspace-owned signals (branch name chosen by the branch creator, commit subjects written by the branch author). PR title/body are ephemeral, often generated or edited by automation, and can carry unrelated context.

The stale-base-ref bug occurs because after git merge origin/<base> into a branch whose local <base> ref is outdated, commits reachable from HEAD but not from the stale local ref appear as "new" in a base..HEAD walk — these are actually the advanced base's commits, not branch work. First-parent walk + explicit exclusion of both local and remote base refs keeps evidence scoped correctly.

Risks / Follow-Ups

None. Only changes what counts as valid link evidence; existing valid evidence (branch name, commit subjects) continues to work. All association and git-service tests pass, including three new regressions for each contamination vector.

---

Generated by RalphX

[codecov]

Codecov Report

❌ Patch coverage is 88.23529% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src-tauri/src/application/git_service/query.rs	86.48%	5 Missing ⚠️
...tion/agent_workspace_external_pr_reconciliation.rs	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!