Implement Self-Evolving Project Skills v2 run 24 - #919
Draft
adriandemian wants to merge 1 commit into
Draft
Conversation
Spec §PR C2 — carry C1's structured `learned:{id}` names through the
existing Claude/Codex composition and launch types, and persist compact
index, full load, composer directive, and interactive stdin usage with
trusted attribution, deterministic IDs, and atomic idempotent batches.
Review repair:
- Fix the stdin metadata assertion to read `exclusion_reason`, the key the
usage builder actually emits (matches learned_skill_substrate_tests).
- Add `learned_skill_usage_tests.rs` covering the launch recorder: dual-kind
emission, metadata provenance, same-run idempotency, distinct-run
separation, unresolved-name suppression, cross-project suppression on both
loops, missing project scope, and contained telemetry persistence failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User Impact
Technical Context
learned-skill-toolsnow distinguishes read and write tool transport headers and reuses runtime identity helpers for read calls.learned_skill_substrateand the learned-skills HTTP handler resolve injected skill names, persist usage events, and suppress unresolved or cross-project records.Risks / Follow-Ups
View full plan
Spec §PR C2 — Injection Telemetry
Implement C2 only on the current automation base: preserve C1’s exact injected project-skill names through the existing Claude and Codex launch structures, then record trustworthy, idempotent usage for compact-index injection, full loads, composer directives, and interactive stdin.
Current-base inspection shows useful substrate is already present: C1 emits structured
learned:{project_skill_id}names; the four usage kinds and usage repository already exist; composer markers and partial composer/stdin recording are landed; and MCP runtime context already carries conversation/run identity. The remaining gaps are that Claude/Codex composition drops injected names, project-skill reads do not send or validate transport-owned attribution headers, usage writes are non-idempotent/non-atomic, and stdin telemetry is currently attempted before transport success.The implementation will extend the existing provider-neutral composition, launch, HTTP/MCP, and ledger seams—without parallel composition types, payload identity, a new usage-kind schema migration, frontend work, or any C3 outcome-linking behavior. Usage telemetry remains best-effort and cannot break an otherwise authorized read or successful delivery; atomic persistence and typed diagnostics prevent partial or falsely attributed rows. Focused behavioral tests will prove both harnesses, exact-name propagation, linkage/scoring policies, invalid/stale identity suppression, project isolation, retry safety, failure isolation, and absence of telemetry on failed or suppressed paths. The linked Blueprint is intentionally unabridged: it contains the complete ten-step implementation sequence, a four-kind scoring/linkage matrix, a production-entry behavioral matrix, focused validation commands, and a proof-obligation completion gate.
Generated by RalphX
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.