chore(admin): fix pre-existing lint errors (CI green)#80
Merged
Conversation
Clear the 13 long-standing biome errors that kept CI red (failure on main since before this work): - CampaignControls.tsx: modal backdrops were clickable <div>s with no keyboard path. Add Escape-to-close onKeyDown + tabIndex (a11y/ useKeyWithClickEvents), mirroring the existing click-to-close; inner content gets matching keydown stopPropagation. Click behaviour unchanged. - CampaignStatusCard.tsx: drop the redundant `case 'IDLE'` that fell through to default with identical output (noUselessSwitchCase). - biome safe autofixes (whitespace / import ordering) elsewhere in admin. No behaviour change; typecheck + builds still pass.
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div | ||
| className="max-h-[80vh] w-full max-w-2xl overflow-y-auto rounded bg-white p-6 shadow-lg" | ||
| onClick={(e) => e.stopPropagation()} | ||
| onKeyDown={(e) => e.stopPropagation()} |
| <div | ||
| className="w-full max-w-md rounded bg-white p-6 shadow-lg" | ||
| onClick={(e) => e.stopPropagation()} | ||
| onKeyDown={(e) => e.stopPropagation()} |
| <div | ||
| role="dialog" | ||
| aria-modal="true" | ||
| tabIndex={-1} |
| <div | ||
| role="dialog" | ||
| aria-modal="true" | ||
| tabIndex={-1} |
| <div | ||
| className="max-h-[80vh] w-full max-w-2xl overflow-y-auto rounded bg-white p-6 shadow-lg" | ||
| onClick={(e) => e.stopPropagation()} | ||
| onKeyDown={(e) => e.stopPropagation()} |
| <div | ||
| className="w-full max-w-md rounded bg-white p-6 shadow-lg" | ||
| onClick={(e) => e.stopPropagation()} | ||
| onKeyDown={(e) => e.stopPropagation()} |
Both are reasoning models (the gateway's inference_defaults give them max_tokens=2048); the chat playground omitted them from REASONING_ALIASES, so they defaulted to 1024 and truncated the thinking phase. Fixes the 2 pre-existing failing ChatPlayground tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the 13 long-standing biome lint errors (a11y on CampaignControls modals + a useless switch case) that kept CI red on main. No behaviour change; typecheck and all builds pass. Makes
pnpm lintexit 0.