Review: Add Craigslist mirror + task verifiers (#60)

[TabsPhasers]

Review: Add Craigslist mirror + task verifiers (#60)

Summary

Review takeover of #60 — the Craigslist mirror by @FlowRays and the task
verifiers by @DEM1TASSE — with fixes for every item of the original
REQUEST CHANGES review (posted on #5). Both original contributors stay
credited: their commits are retained untouched, with three review commits on
top. Please merge with a regular merge (not squash).

Original review resolution

#5 review item	Status	Fix
two save-tasks whose targets are pre-seeded	fixed	seed now pre-saves the Black office chair (id 2) instead of the Ergonomic task chair; task 3 retargeted to the non-pre-saved 2011 Accord EX-L (id 15); the 2006 Accord EX (id 13) stays pre-seeded as task 13's removal target and doubles as a near-miss distractor; verify_0/verify_3 check the initial→after saved-listings delta (3a5ae40)
a save-search that can't set the requested category	fixed	the save-search form exposes a category select and max price; verify_5 enforces name + category_slug=furniture + max_price=200 (3a5ae40)
a half-fixed sqft leak	fixed	the sqft chip is removed from search result cards; the old not is_housing guard only suppressed it on category pages while generic query pages (where tasks 1/4 search) leaked listing sqft as an answer shortcut (da8d380)
image/content mismatches	fixed	real photos are used only when the listing title matches the photo's own filename (20 exact matches — the 2006 Accord EX no longer carries the 2011 EX-L's photo); all other listings get a deterministic generated SVG placeholder, so 183/183 listings have a truthful, regenerable image; galleries collapse to the listing's own image (45daffd)
an incomplete hide feature	fixed	added POST /listing/<id>/unhide and a "hidden listings" panel on the account page; hiding was previously irreversible (da8d380)
a non-category-aware post form	fixed	field groups carry data-groups and toggle per selected category via progressive-enhancement JS; posting a bike no longer shows bedrooms/sqft/compensation (da8d380)
inconsistent favorites labels	fixed	header badge and nav links unified to "saved"; object-specific headings ("saved listings", "saved searches") unchanged (da8d380)

Review changes

• sites/craigslist/seed_data.py — pre-seeded saved set {office chair 2,
  2006 Accord EX 13, Berkeley BART studio 21}; deterministic image assignment
  (title-matched real photos + generated SVG placeholders written at seed time)
• sites/craigslist/tasks.jsonl — task 3 retargeted to the 2011 Accord EX-L;
  task 0/3 rubrics updated (no answer keys added)
• sites/craigslist/verify/ — initial→after delta predicates for the save
  tasks (verify_0, verify_3), distractor guard on task 3, three-field
  save-search enforcement (verify_5), updated keep-set (verify_13),
  saved_searches_for extended with category_slug (verify_lib)
• sites/craigslist/app.py, templates/ — unhide route + account panel,
  category-aware post form, sqft chip removal, saved vocabulary
• README.md — site-count consistency (17)

Asset delivery status

• HF PR: https://huggingface.co/datasets/ChilleD/WebHarbor/discussions/72
  ("feat(craigslist): add craigslist asset bundle (reviewed seed for WebHarbor Add Craigslist mirror + task verifiers (site by @FlowRays, verifiers by reviewer) #60)")
• Status: Open / blocking — replaces the stale Add Craigslist mirror #5 bundle (old seed,
  mismatched image pool)
• Bundle: craigslist.tar.gz, 523,402 bytes, 198 members, SHA-256
  9ea3eeefff3bed47337531407ff75634ffbae69d680fd70ebd671c1134dda93a
  (HF commit 672962a)
• .assets-revision: pending — the current pin 54882a6a… predates
  craigslist and cannot fetch this site. It will be repinned to the HF Add Target mirror + task verifiers (site rebuilt from real target.com data) #72
  merge commit with a clean fetch_assets.sh craigslist check after merge.
  Do not merge this PR before the HF PR is merged.

Validation

Deterministic single-site review environment (review image
webharbor-pr60-craigslist:45daffd, canonical port 40016):

• build / /_health (183 listings) / control-plane health: PASS
• reset byte-identity: instance == instance_seed (edcd84fe…) after every
  reset: PASS
• seed determinism: seed_data.py regenerates a database whose full dump
  equals the packaged seed: PASS
• no-op baseline: 20/20 verifiers correctly FAIL (exit 1)
• task-specific negatives: visit-only saves (tasks 0/3), task 3 without a
  save, task 13 wrong-item removal all FAIL; positives PASS
• full-matrix real-browser runs: Round A on the original head (20/20 verifier
  PASS — which is exactly how the two pre-seeded save-task false positives
  surfaced), Round B on the fixed seed (20/20 PASS with real DB deltas, e.g.
  saved set [2,13,21] → [1,2,13,21] for task 0), Round C after the five site
  fixes (7/7 affected tasks PASS)
• rubric judge (main-agent) vs deterministic verifiers: 20/20 agree
  (main-judged; no independent LLM judge was available in this environment —
  recorded as a limitation)

Known remaining issues (disclosed; outside the task contract)

• 320 px viewports show slight horizontal overflow on home/search/detail
  (390 px is clean)
• text search can surface cross-category results; for-sale category links on
  the homepage use text queries rather than the category route
• some filler seed rows carry scrambled category/area pairs
• independent LLM judge and independent pure-visual subagent trajectories were
  not run (environment limitation, see Validation)

Scope

• Original site (@FlowRays) and verifier (@DEM1TASSE) commits retained
  untouched
• Excluded: reviewer run evidence, local static images (the image set ships in
  the HF bundle), review tooling
• No shared framework changes

Blocking checklist

• HF PR #72
  merged → .assets-revision repinned to the merge commit → clean
  fetch_assets.sh craigslist verified

Reviews #60. Site track: #5.