Review: Bandcamp mirror + task verifiers (site by @reacher-z, verifiers by reviewer) (#79) - #104
Draft
TabsPhasers wants to merge 8 commits into
Draft
Review: Bandcamp mirror + task verifiers (site by @reacher-z, verifiers by reviewer) (#79)#104TabsPhasers wants to merge 8 commits into
TabsPhasers wants to merge 8 commits into
Conversation
…am tone Drop the artificial 24-tag limit on Discover so tag-filtered tasks reach their targets, and replace benchmark-facing copy (mock checkout, seeded benchmark users, About This Mirror) with upstream-style user copy.
…ma fixtures Rewrite the 18 judge rubrics as deterministic fact checkpoints derived from the initial database, rework verify_lib around identity/format invariants, and add seed/schema fixture tests plus a task 9/11 regression test. No question text, mappings, or answers change.
…ayout Generated SVG (seed_data): auto-fit cover/merch label text so long titles stay inside the viewBox and backdrop instead of clipping, widen merch backdrops, and stop truncating merch titles mid-word. CSS: stop stat pills stretching inside album-copy grid; keep single-item release/merch grids at card width (auto-fill); show full merch art at its native 5:6 ratio instead of a 1:1 crop that cut the bottom label; widen the purchase column and shrink select text so option prices are not hidden under the dropdown arrow; give the category pill row a visible scroll affordance; deepen the artist hero overlay so stats stay legible. JS: ignore Enter on focused selects so it cannot implicitly submit the cart form with the default variant, and emit English native-validation messages regardless of browser locale.
Integrate upstream additions (Rotten Tomatoes, Compass, Walmart Careers) and move Bandcamp from site 23 (port 40021) to site 25 (port 40024): registry lists in websyn_start.sh/control_server.py stay identical, Dockerfile EXPOSE and README counts/ports updated, bandcamp app default port and task web fields moved to 40024.
The shared preview-toggle handler wrote "Preview mock" once a panel was collapsed again, so every album page showed the wrong label on the second click. Restore it to "Preview" to match the initial button text. Found by manual browse after visual QA; cosmetic only, no task verifier or tasks.jsonl impact.
TabsPhasers
marked this pull request as draft
September 12, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Reviewer pass on #79 (Bandcamp mirror, site by @reacher-z): site-quality remediation, grading contract (18 deterministic verifiers +
judge_rubric), registry integration as site 25 (port 40024), and final-environment validation. Replaces the author'sreview/bandcamp-verifiersstate with the reviewed/fixed version.Related PRs
Changes
auto-fit→auto-fill); native<select>Enter implicit submit; locale-dependent validation bubbles; preview-toggle label (Previewafter collapse).sites/bandcamp/verify/plus an Englishjudge_rubricper task; ground truth stays inside verifiers,tasks.jsonlcarries noanswerkey.websyn_start.sh,control_server.py,Dockerfile, docs in sync); task metadata unchanged vs the author's tasks.2558779a6e90e67eb2aa99554f6df3f5a0d567324c08ff461772762b5c67ec4a);/reset/bandcamprestores byte-identical.Seed size (major models)
albums 80,artists 40,tracks 400,format_variants 444,merch_items 80,album_tags 320,tags 90,users 4,orders 5,cart_items 9,wishlist_items 16,fan_collection_items 6,labels 10,genres 12,scenes 9.Verification
/reset/bandcamp: byte-identical (md5(instance) == md5(instance_seed)); full-sitereset-all25/25 ready, e.g.{"pid":538,"ready":true,"site":"bandcamp"}.webharbor:pr79-final, 25 sites): control health 25/25 alive;41000-41024all HTTP 200.bandcamp-007) with the deterministic verifiers, driven end-to-end by native pure-vision actors; 18/18 no-op baselines FAIL healthily (verifier exit 1).Known limitations
<select>popups are not rendered by headless Chromium; tasks remain completable via visible focus + keyboard, and the site-side Enter implicit-submit issue was fixed.Links
Scope notes
sites/bandcamp/**(site + verifiers) and the minimal registry/port/docs updates for site 25.Reviews #79replacement PR; noCloses #79.Blocking checklist
ChilleD/WebHarbordiscussions#69 merged by maintainer.assets-revisionbumped to the HF merge commit; cleanfetch_assets.shresolvesbandcamp.tar.gz