Integrate OSU review #120 with grading fixes and task GIF report - #125
Merged
Merged
Conversation
Keep coach, records, titles, research directors, program credits/deadlines, department chairs, and news bylines on detail pages so listing/search shortcuts cannot complete the benchmark tasks. Drop the redundant "Dean" prefix from college names so Academics renders "Dean: <name>". Co-authored-by: Lxr-max <Lxr-max@users.noreply.github.com>
Independent reviewer grading contract for PR #12: one verify_N.py per accepted task, shared verify_lib, verifier_path + rule-only judge_rubric on all 20 rows, and a verify/tests harness (no-op, shortcut, wrong-answer, listing-without-detail, swapped comparison, missing filter, DB mutation). Re-anchor task 4 so the expenditure amount is not named in the question. Co-authored-by: Lxr-max <Lxr-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates #120 with follow-up OSU grading and layout fixes, as requested by the maintainer. Original commits are retained: OSU mirror by @richard-peng-xia (#12), reviewer contribution by @Lxr-max (#120). This PR delivers the combined result; no changes were pushed to the contributor's fork.
8abe530.Review report and GIF evidence
Full review/integration report, including the per-task GIF index.
The preserved local evidence package contains 40 organized GIFs: before and after for each of 20 tasks, plus action logs, screenshots, DB snapshots, control verdicts, and exact file hashes. All GIF frames were decoded and the gallery was checked in a browser. Heavy evidence is outside git and the Docker context; it is not publicly hosted. In the review workspace, forward port 43220 to view
http://localhost:43220/; the report explains the package location. Original and corrected previews remain on 42020 and 43020.Verification performed
webharbor:pr120-integrated-20260917, IDsha256:ef63ab0a9cabb89e6491d4bc8e1d8d14a25fb8ea8a5afe8d990d3c7164edb320.9245a33b2649e365fcb5896ca62e13b4; reset-all completed in 1.16 seconds.Limits / release scope
The secondary LLM judge was not run (API/model configuration unset). Deterministic factual parsing is not unrestricted natural-language entailment, and this is not a new live-source fact audit. No asset upload, Docker publication, or deployment is included. The owned integration test container was stopped; existing previews and the GIF gallery are preserved.