Add Versus mirror site - #41
Conversation
Susan571
left a comment
There was a problem hiding this comment.
Reviewer checklist (WebHarbor Review Guide)
Reviewer note: Source-level review (checked out pull/41/head). The mechanical Docker pipeline (build, curl 200, md5 reset) was not run in my environment — please pair with a Docker-capable mechanical pass.
Visual fidelity: ❌ FAIL
- Compare/rankings IA fits versus.com conceptually and templates are richer than a bare skin, but all product imagery is the
/product-art/<slug>.svgplaceholder (shapes + brand initials + "{score} Versus Score"). No real product photos → fails the real-images check.
Functional depth: ✅ PASS
- Category browse, brand/price/min-score filters, product detail, side-by-side compare with a winner, compare-picker, rankings, search, login, save-comparison, account.
- Data quality is strong: real product names with plausible real specs (Sennheiser Momentum 4 = 60 h battery, Sony WH-1000XM5 = 30 h, Nikon Z8 = 45.7 MP, RTX 4080 Super = 16 GB/320 W). Best data of this contributor's set.
Task quality: ⚠️ Request changes (10 tasks)
- Good:
Versus--1(headphones ≥50 h → only Momentum 4 qualifies; real distractors),Versus--3(camera ≥40 MP → Z8 + X-T5),Versus--6(phones ≤ $1000 highest score → excludes S24 Ultra at $1299). These need spec-reading with near-miss distractors. - Leak risk: the Versus Score is rendered on cards/art, so score-comparison tasks (
--0,--2) may be answerable without opening detail. Move the deciding value behind the detail/compare page. - Only 10 tasks (need 15–20);
Versus--5leaks the password.
Verdict: Request changes
(1) Use real product images; (2) hide the score on cards for score-comparison tasks; (3) provide 15–20 tasks with more ≥5-step reasoning; (4) remove the credential leak. This is the closest of the contributor's set to acceptable on functionality/data.
|
Hi @Sun-sunshine06 — claiming this PR for review. I'll pick up the reviewer role described in I'll open a separate Please let me know if you're already working on these — happy to coordinate instead of duplicating. |
|
Opened the Review PR: #111 (Draft). Your commit is kept as-is, rebased onto current Three things I could not settle and left in the Draft description rather than paper over — the visual gap against versus.com, the placeholder product art (@Susan571's finding, confirmed), and what looks like an invented Versus Score while the specs and MSRPs check out as real. Those are yours to weigh in on if you disagree with any of it. One correction to the earlier review for the record: The environment and grading side is finished and reproducible; commands are in the PR description. |
Summary
Verification
Note