Review: complete BoardGameGeek environment and grading contract (#35)

[jackjin1997]

Summary

Reviewer-owned continuation of #35, preserving the original BoardGameGeek contribution and attribution while integrating it after current main as the 25th mirror on port 40024.

The review fixes environment, task-contract, verifier, responsive-layout, and broad visual-fidelity issues. All 21 accepted tasks retain deterministic grading. The review is complete and this PR is ready for maintainer review.

Changes

• preserve the contributor implementation and public attribution to @hqhq1025
• correct direct Flask startup, rating aggregation, registration errors, and task-required collection/GeekList state
• replace the inherited retro shell and restore the full homepage, browse, and game-detail hierarchy
• register BoardGameGeek after the existing 24 sites and align every task URL with port 40024
• keep one deterministic verifier and one non-answer-leaking rubric per task
• repair four task-contract defects: Task 8 answer leakage, hidden filter/sort requirements in Tasks 11/18, and click-only recognition for stateful form submission

Task quantity and quality

• accepted tasks: 21; verifiers: 21; mapped executions: 21
• portfolio: 16 read/compare tasks, 5 persistent-write tasks, 7 authenticated tasks, and 10 tasks with at least five recorded UI actions
• 21 is already above the public 15–20 recommendation; no weak task was added merely to increase the count
• all rows contain the required task/rubric/verifier contract and no answer key

Verification completed

• exact-head 25-site full-environment smoke: PASS at ebb4c55427114d4461762da12174603b5d2e6436
• complete image build: PASS, 4.92 GB; the runner began with 87 GiB free
• BoardGameGeek environment/verifier tests: 11/11 passed
• all-site checks before and after reset-all: 25/25 HTTP 200 and 25/25 healthy
• BoardGameGeek dirty-state reset: byte-identical PASS; reset-all: 25/25 ready in 6 seconds, with the target DB still seed-identical afterward
• public smoke evidence artifact, artifact ZIP SHA-256 6f2b746fca4244f541f4f55976f8138239786045cc4bc46c4a2b3593a0e29656
• verifier suite: 91/91 passed, covering positives, legal alternatives, incorrect/incomplete answers, answer/state without navigation, prompt-permitted paths, and keyboard form submission
• current-head mapped deterministic evaluation: 21/21 passed; Task 8 uses a fresh homepage-origin run and the other 20 reuse unchanged application/asset executions
• independent Claude Code blind review: manifest valid (228/228 references), 21 PASS / 0 FAIL, using Claude Fable 5.1
• desktop and 390 px captures of home, browse, and Gloomhaven detail: HTTP 200, no broken images, and no page-level horizontal overflow; the restored homepage renders 101 local images
• owner visual comparison accepted after the lower-page restoration: “这个还挺像的”
• reviewed asset archive: 11,345 safe members; archive SHA-256 970c6618e39a37920b228abd976d4756db126239ab4b4fa48b37b03b81cad6d1; seed SHA-256 5a00124fa1e523678c1010ea74a2c1d8ed5febd18f71cf54632bec83a07612b1

Guided/source-aware runs prove task feasibility and scoring behavior; they are not independent exploration-performance measurements.

Current integration

• review head: ebb4c55427114d4461762da12174603b5d2e6436
• review tree: 09fc88efd6b20b50140deeecef43596893fe52c4
• current-main parent: 36004932bdf82afbe36dc14e00f66841eccf9946
• GitHub reports this PR as mergeable-clean
• the exact remote source tree was reconstructed and verified locally across 1,334 tracked files; launcher/control registries match at 25 sites and Python syntax checks pass

Asset dependency and maintainer handoff

The matching asset remains open in HF PR #25 by the original contributor. Its immutable revision 6737719a7eeb8d9b5fba77072d455e0d9afd2a93 is the revision tested above, exposes the reviewed archive, and currently reports no file conflicts.

This GitHub PR is ready for review, but the contribution is not directly mergeable end-to-end until maintainers:

1. merge HF PR Add Compass real-estate mirror (port 40015) #25;
2. update .assets-revision here to the resulting HF merge commit and confirm the BoardGameGeek archive hash remains unchanged; and
3. merge this GitHub PR after final review.

Non-blocking P2 polish remains: the generic designer index shows a zero game-count label for designers, and user search uses uppercase-first SQLite binary collation. Neither affects the accepted tasks or their results.

Reviewer agents will not merge either PR.

Original PR: #35