fix: WASMビルド時のコンパイル警告を解消 - #9
Merged
Merged
Conversation
- ##__VA_ARGS__ (GNU拡張) を標準の , __VA_ARGS__ に変更 - sign-conversion警告: int系→size_tの暗黙変換にstatic_castを追加 - 対象: common.h, image_buffer.h, pixel_format.h, rgba8_straight.h, viewport.h, distributor_node.h, matte_node.h, sink_node.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
##__VA_ARGS__（GNU拡張）を標準の, __VA_ARGS__に変更（-Wgnu-zero-variadic-macro-arguments解消）int系 →size_tの暗黙変換にstatic_cast<size_t>()を追加（-Wsign-conversion解消）int→int_fast16_tの暗黙変換にstatic_castを追加（-Wimplicit-int-conversion解消）修正ファイル（8ファイル）
core/common.h- デバッグログマクロimage/image_buffer.h- フォーマット変換・ブレンド呼び出しimage/pixel_format.h- convertFormat関数image/pixel_format/rgba8_straight.h- blendUnderStraightのポインタ差分image/viewport.h- copyRowDDABilinearのフォーマット変換nodes/distributor_node.h- initPortsの引数nodes/matte_node.h- フォーマット変換呼び出しnodes/sink_node.h- フォーマット変換呼び出しTest plan
pio test -e test_native全202テストケース PASSED