fix(release): pin skills version in Makefile for traceability#152
Conversation
|
Warning Review limit reached
More reviews will be available in 50 minutes and 58 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR restructures Claudio Skills version management by removing input validation from the release workflow, shifting to tag-based version defaults in the Makefile, and adding Renovate automation to keep the version current. ChangesClaudio Skills Version Management
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ca2da11 to
9bbf6da
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 31-33: Update the comment above the CS_REF_TYPE and CS_REF
defaults to make it explicit that the Makefile defaults track the stable tag
(CS_REF_TYPE ?= tag and CS_REF ?= v0.6.2) and that developers should explicitly
override to build from the branch by passing CS_REF_TYPE=branch CS_REF=main;
reference the variables CS_REF_TYPE and CS_REF in the comment so it reads like:
"Default: build from stable tag (CS_REF_TYPE=tag, CS_REF=v0.6.2). To build from
the latest branch, override with CS_REF_TYPE=branch CS_REF=main."
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 6c07c131-be75-4fc2-b34d-4d19d8889cec
📒 Files selected for processing (3)
.github/workflows/release.ymlMakefilerenovate.json
💤 Files with no reviewable changes (1)
- .github/workflows/release.yml
- Pin CS_REF to v0.6.2 (tag) instead of main (branch) as default - Add Renovate custom manager to auto-bump claudio-skills version - Remove skills_ref workflow input — release uses Makefile defaults - Update comment to document development override pattern The skills version is now a tracked dependency in git. Renovate creates bump PRs on new releases, giving each release a distinct commit. This replaces the phantom workflow input that was invisible in git history. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jakub Rusz <jrusz@redhat.com>
9bbf6da to
2a743ad
Compare
Summary
CS_REFto a specific skills tag (v0.6.2) in the Makefile instead of defaulting tomainskills_refworkflow input from the release workflow — builds use Makefile defaultsProblem
Three issues with the current release workflow (reported by @ppitonak):
skills_refis a workflow input never recorded in git — you must inspect the container image to find which skills version a release uses--generate-notesalways diffs against v0.6.1 because all v0.7.x tags target the same commitSolution
Make the skills version a tracked dependency — pin it in the Makefile, let Renovate bump it. Each Renovate PR creates a new commit, so releases naturally get distinct SHAs and meaningful changelogs.
The
?=pattern preserves local override for development:CS_REF_TYPE=branch CS_REF=main make oci-build.Test plan
git ls-remoteresolves pinned tag to correct SHAv0.8.0-rc1) with only theversioninput🤖 Generated with Claude Code
Summary by CodeRabbit