Skip to content

fix(release): pin skills version in Makefile for traceability#152

Merged
jrusz merged 1 commit into
mainfrom
worktree-impl-claudio-release-traceability
Jun 4, 2026
Merged

fix(release): pin skills version in Makefile for traceability#152
jrusz merged 1 commit into
mainfrom
worktree-impl-claudio-release-traceability

Conversation

@jrusz

@jrusz jrusz commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pin CS_REF to a specific skills tag (v0.6.2) in the Makefile instead of defaulting to main
  • Add Renovate custom manager to auto-bump the skills version on new releases
  • Remove skills_ref workflow input from the release workflow — builds use Makefile defaults

Problem

Three issues with the current release workflow (reported by @ppitonak):

  1. Same commit: v0.7.1, v0.7.2, v0.7.3 all tag commit f7420fc — multiple releases are indistinguishable in git history
  2. Invisible skills_ref: skills_ref is a workflow input never recorded in git — you must inspect the container image to find which skills version a release uses
  3. Broken changelog: --generate-notes always diffs against v0.6.1 because all v0.7.x tags target the same commit

Solution

Make the skills version a tracked dependency — pin it in the Makefile, let Renovate bump it. Each Renovate PR creates a new commit, so releases naturally get distinct SHAs and meaningful changelogs.

The ?= pattern preserves local override for development: CS_REF_TYPE=branch CS_REF=main make oci-build.

Test plan

  • YAML and JSON syntax validation
  • git ls-remote resolves pinned tag to correct SHA
  • CI builds PR image using pinned skills version
  • After merge: trigger a test release (e.g. v0.8.0-rc1) with only the version input

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated build configuration defaults for dependencies.
    • Enhanced workflow automation for dependency version updates.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jrusz, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 58 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 678f2afd-c34f-4040-a04d-852f2e6e6c4c

📥 Commits

Reviewing files that changed from the base of the PR and between 9bbf6da and 2a743ad.

📒 Files selected for processing (3)
  • .github/workflows/release.yml
  • Makefile
  • renovate.json
📝 Walkthrough

Walkthrough

This PR restructures Claudio Skills version management by removing input validation from the release workflow, shifting to tag-based version defaults in the Makefile, and adding Renovate automation to keep the version current.

Changes

Claudio Skills Version Management

Layer / File(s) Summary
Release workflow validation restructure
.github/workflows/release.yml
The Validate inputs step now validates only inputs.version format against the vMAJOR.MINOR.PATCH(-suffix)? pattern; skills_ref validation is removed entirely. Build environment variables continue unchanged.
Claudio Skills version defaults and Renovate automation
Makefile, renovate.json
Makefile defaults shift from CS_REF_TYPE ?= branch and CS_REF ?= main to CS_REF_TYPE ?= tag and CS_REF ?= v0.6.2. A new Renovate customManagers rule detects CS_REF ?= vX.Y.Z patterns in the Makefile and automatically updates them from aipcc-cicd/claudio-skills GitHub releases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • aipcc-cicd/claudio#151: Overlaps on release automation work, both PRs modify .github/workflows/release.yml input handling around skills_ref and update Makefile/renovate.json Claudio Skills defaults.
  • aipcc-cicd/claudio#146: Both PRs update Renovate configuration to target the Makefile's CS_REF ?= vX.Y.Z pattern.
  • aipcc-cicd/claudio#134: Both PRs shift Makefile defaults for Claudio Skills references from branch-based to tag-based values.

Suggested reviewers

  • gnaponie
  • ppitonak
  • ktdreyer

Poem

🐰 A workflow once fretted about every skill,
But now trusts the defaults to bend to its will,
Renovate watches with eyes sharp and keen,
Auto-bumping the tags to the latest scene! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(release): pin skills version in Makefile for traceability' accurately summarizes the primary change: pinning the Claudio Skills reference to a specific tag version (v0.6.2) instead of the 'main' branch in the Makefile, which directly supports the goal of release traceability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch worktree-impl-claudio-release-traceability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jrusz jrusz force-pushed the worktree-impl-claudio-release-traceability branch from ca2da11 to 9bbf6da Compare June 3, 2026 07:30
@jrusz jrusz changed the title fix(release): add release commit for traceability fix(release): pin skills version in Makefile for traceability Jun 3, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Makefile`:
- Around line 31-33: Update the comment above the CS_REF_TYPE and CS_REF
defaults to make it explicit that the Makefile defaults track the stable tag
(CS_REF_TYPE ?= tag and CS_REF ?= v0.6.2) and that developers should explicitly
override to build from the branch by passing CS_REF_TYPE=branch CS_REF=main;
reference the variables CS_REF_TYPE and CS_REF in the comment so it reads like:
"Default: build from stable tag (CS_REF_TYPE=tag, CS_REF=v0.6.2). To build from
the latest branch, override with CS_REF_TYPE=branch CS_REF=main."
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6c07c131-be75-4fc2-b34d-4d19d8889cec

📥 Commits

Reviewing files that changed from the base of the PR and between ab244b5 and 9bbf6da.

📒 Files selected for processing (3)
  • .github/workflows/release.yml
  • Makefile
  • renovate.json
💤 Files with no reviewable changes (1)
  • .github/workflows/release.yml

Comment thread Makefile
- Pin CS_REF to v0.6.2 (tag) instead of main (branch) as default
- Add Renovate custom manager to auto-bump claudio-skills version
- Remove skills_ref workflow input — release uses Makefile defaults
- Update comment to document development override pattern

The skills version is now a tracked dependency in git. Renovate
creates bump PRs on new releases, giving each release a distinct
commit. This replaces the phantom workflow input that was invisible
in git history.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jakub Rusz <jrusz@redhat.com>
@jrusz jrusz force-pushed the worktree-impl-claudio-release-traceability branch from 9bbf6da to 2a743ad Compare June 3, 2026 07:39
@jrusz jrusz requested a review from adrianriobo June 3, 2026 07:54
@jrusz jrusz merged commit 3ea7287 into main Jun 4, 2026
6 checks passed
@jrusz jrusz deleted the worktree-impl-claudio-release-traceability branch June 4, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants