-
Notifications
You must be signed in to change notification settings - Fork 412
Centralize toolchain and target compatibility version. #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+71
−53
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
59cbd49
Centralize toolchain and target compatibility version.
ff15180
Add java 22 to gh actions
rossbacher b65de35
setup java 22
rossbacher 0815bbe
fix yml
rossbacher d0753e8
Fix yml
rossbacher 7b42738
fix dist
rossbacher 1746716
fix dist
rossbacher 5e7a16f
Merge branch 'master' into rossbacher-cleanupToolchains
rossbacher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,53 @@ tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).all { | |
| } | ||
| } | ||
|
|
||
| // Apply consistent JVM toolchain and target to all subprojects | ||
| subprojects { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. kind of crazy how hard it is just to set a standard version for the whole project 😂
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, but better to have it spread out everywhere... |
||
| afterEvaluate { | ||
| def toolchainVersion = rootProject.ext.jvmToolchainVersion | ||
| def targetVersion = rootProject.ext.jvmTargetVersion | ||
|
|
||
| // For Kotlin projects (both pure JVM and Android) | ||
| if (plugins.hasPlugin('org.jetbrains.kotlin.jvm') || plugins.hasPlugin('kotlin') || | ||
| plugins.hasPlugin('kotlin-android') || plugins.hasPlugin('org.jetbrains.kotlin.android')) { | ||
| kotlin { | ||
| jvmToolchain(toolchainVersion) | ||
| } | ||
| tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach { | ||
| compilerOptions { | ||
| jvmTarget = org.jetbrains.kotlin.gradle.dsl.JvmTarget.@Companion.fromTarget(targetVersion.toString()) | ||
| } | ||
| } | ||
| } | ||
| // For Java-only projects (without Kotlin) | ||
| else if (plugins.hasPlugin('java') && !plugins.hasPlugin('kotlin-dsl')) { | ||
| java { | ||
| toolchain { | ||
| languageVersion = JavaLanguageVersion.of(toolchainVersion) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // For Android projects, also set compileOptions | ||
| if (plugins.hasPlugin('com.android.library') || plugins.hasPlugin('com.android.application')) { | ||
| android { | ||
| compileOptions { | ||
| sourceCompatibility = JavaVersion.toVersion(targetVersion) | ||
| targetCompatibility = JavaVersion.toVersion(targetVersion) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // For pure Java projects | ||
| if (plugins.hasPlugin('java') && !plugins.hasPlugin('kotlin-dsl')) { | ||
| java { | ||
| sourceCompatibility = JavaVersion.toVersion(targetVersion) | ||
| targetCompatibility = JavaVersion.toVersion(targetVersion) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| def getReleaseRepositoryUrl() { | ||
| return hasProperty('RELEASE_REPOSITORY_URL') ? RELEASE_REPOSITORY_URL | ||
| : "https://oss.sonatype.org/service/local/staging/deploy/maven2/" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,3 @@ android { | |
| unitTests.returnDefaultValues = true | ||
| } | ||
| } | ||
|
|
||
| kotlin { | ||
| jvmToolchain(11) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
25 did not work with robolectric and it was not worth to figure it out.