quickstart: Fix silent failure when .gitignore existsThis fixes issue…#1583
Open
harshil2424 wants to merge 1 commit into
Open
quickstart: Fix silent failure when .gitignore existsThis fixes issue…#1583harshil2424 wants to merge 1 commit into
harshil2424 wants to merge 1 commit into
Conversation
…irspeed-velocity#1582 where \�sv quickstart\ aborted if a \.gitignore\was present. The command now appends ASV-specific patterns to the existingfile instead of treating it as a template conflict.
Author
|
Fixes #1582 |
HaoZeke
requested changes
Apr 20, 2026
Member
HaoZeke
left a comment
HaoZeke
left a comment
There was a problem hiding this comment.
IMO this is a rather large change to the existing behavior. My preferred fix would be a noisier / clearer error message instead of changing the way asv works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… #1582 where asv quickstart aborted if a .gitignorewas present. The command now appends ASV-specific patterns to the existingfile instead of treating it as a template conflict.