feat: implement CSS-variable theme management and dynamic search feed… #117
+47
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for library-man failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several meaningful improvements to the project's architecture and user interface:
Centralized Theme Management: Refactored the dark mode logic to use CSS variables and class-based styling within src/assets/styles/App.css. This replaces manual DOM manipulation in src/App.jsx, ensuring a smoother transition and consistent state across all pages.
Bug Fix (Syntax Error): Fixed a typo in src/pages/Login.jsx where the section tag used {$mode} instead of ${mode}, which prevented the theme from applying correctly to the login container.
Dynamic Search Feedback: Added a status header in src/pages/Books.jsx that provides real-time feedback to the user (e.g., "Searching for..." or "Result found") based on the isLoading and searchResult states from the Global Context.
UI Polish: Implemented smooth transitions for theme switching and improved the visual hierarchy of the search page.