fix(panel): convert all consecutive alert blockquotes to panels - #8
Open
adamcarlile wants to merge 1 commit into
Open
adamcarlile wants to merge 1 commit into
adamcarlile wants to merge 1 commit into
Conversation
Goldmark's ast.Walk advances siblings via c.NextSibling() after visiting each child. ReplaceChild sets the replaced node's NextSibling to nil, which terminates the walk early and causes subsequent alert blockquotes to remain unconverted. Split the panelTransformer into a collect phase (read-only walk) and a transform phase (mutate collected nodes) to avoid modifying the tree during traversal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goldmark's ast.Walk advances siblings via c.NextSibling() after visiting each child. ReplaceChild sets the replaced node's NextSibling to nil, which terminates the walk early and causes subsequent alert blockquotes to remain unconverted.
Split the panelTransformer into a collect phase (read-only walk) and a transform phase (mutate collected nodes) to avoid modifying the tree during traversal.