Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde_jsonwithserde/flexbuffers.Output example:
*Numbers were off by a bit from the Mar 2nd meeting version because I eyeballed the size from the number in bytes for the meeting and used base 1000 instead of 1024.
rulesets.The problem is in
span. The egglog frontend uses spans throughout its ASTs for debugging.However, the default implementation generated by
#[derive(serde::Serialize)]performs a deep copy forArc<SrcFile>, which means every node in the AST would carry a copy of the whole input egglog program, causing a significant blowup that scales quadratically with the input file size (# AST nodes * filesize).spanserialization bottleneck.I implemented a quick hack that serializes
spanintounit. For the example tested above, we now have a 300x overall reduction and a 1600x reduction forrulesetsandfunctions:Run
extractrunmode oneasteregg,herbie-hamming,herbie-math-rewrite,herbie-math-taylorbenchmarks.Fixed minor bugs.
Added radio buttons to pick a benchmark.
Added a new chart to show the speedup of using Poach vs. Vanilla.
Added a checkbox for including deserialization time in Poach time.
Get a nightly run. Link
List what research questions to ask and how to look at the data.
Add file size statistics to the nightly report. (Link in the #poach channel)
Is the serialization size linear to the egraph size? - Yes (~500bytes per tuple)
Is the serialization/deserialization time linear to the serialization size? - Yes
Clean up hacks.
Get another nightly run. Link Results reproduced.
Investigate if egglog's hashcon works as I thought it does