Skip to content

Added command to open caniuse.com for feature.#9

Open
nchutchind wants to merge 2 commits into
akamud:masterfrom
nchutchind:master
Open

Added command to open caniuse.com for feature.#9
nchutchind wants to merge 2 commits into
akamud:masterfrom
nchutchind:master

Conversation

@nchutchind
Copy link
Copy Markdown

Used the same as the default behavior, but with a different shortcut will open the browser to caniuse.com/selectedWord.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 00eaea8 on nchutchind:master into 8fb16ad on akamud:master.

@akamud
Copy link
Copy Markdown
Owner

akamud commented Jul 16, 2016

Hi, thank you for sending this, I looked at the code and I see that you are using the selected word to send to CanIUse, they use keywords for most of the rules, so just sending the selected word won't work for many rules.

To address this I started using a "mapping" file so it always send the correct keyword to CanIUse. You can see it in use in here.

You should change your code to use this mapping file before calling caniuse.com

@yangg
Copy link
Copy Markdown

yangg commented Oct 11, 2016

I think click the status bar to open caniuse.com is also a good feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants