Skip to content

fix: carry plugin-created .factory/ subdirs into worktrees #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shivchander wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: carry plugin-created .factory/ subdirs into worktrees #1265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f5c37
fix: widen CycleState.mode from Literal to str for plugin modes
shivchander Aug 14, 2026
fb516de
fix: carry plugin-created .factory/ subdirs into worktrees
shivchander Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions factory/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,24 +491,7 @@ class CycleState(BaseModel):

cycle_id: str
started_at: datetime
mode: Literal[
"build",
"create",
"deep-qa",
"deep-research",
"design",
"discover",
"founder",
"improve",
"meta",
"parallel-improve",
"qa",
"refine",
"research",
"review",
"study",
"swebench",
]
mode: str
initial_prompt: str = ""
respawns: int = 0
runner_name: str | None = None
Expand Down
10 changes: 10 additions & 0 deletions factory/worktree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,16 @@ def create_worktree(
if backlog_src.exists():
shutil.copy2(backlog_src, wt_factory / "strategy" / "backlog.md")

# Copy remaining plugin-created subdirectories not already handled.
_handled = set(_SHARED_SYMLINK_ENTRIES) | set(_COPY_ENTRIES)
if factory_dir.is_dir():
for child in factory_dir.iterdir():
if child.name in _handled or not child.is_dir():
continue
dst = wt_factory / child.name
if not dst.exists():
shutil.copytree(child, dst)

log.info("worktree_created", branch=branch, path=str(wt_dir))

try:
Expand Down
Loading