Skip to content

fix: override strategist post_checks in design_workflow() with dual-format sentinels #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crqu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: override strategist post_checks in design_workflow() with dual-format sentinels #1324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions factory/workflow/definitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,18 @@ def design_workflow(just_plan: bool = False) -> Workflow:
update={"reads": (node.reads or set()) | {".factory/strategy/study-combined.md"}},
)

_strat = wf.nodes["strategist"]
wf.nodes["strategist"] = _strat.model_copy(
update={"post_checks": [
ArtifactCheck(
path=".factory/strategy/current.md",
must_exist=True,
min_size=200,
must_contain=["### Phase 1", "### Hypotheses"],
)
]},
)

wf.edges.extend(
[
*s_edges,
Expand Down
6 changes: 3 additions & 3 deletions tests/test_verification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,16 +521,16 @@ def test_build_workflow_has_post_checks(self) -> None:
assert "code_reviewer" in wf.nodes
assert "adversarial_tester" in wf.nodes

def test_design_workflow_inherits_post_checks(self) -> None:
def test_design_workflow_overrides_post_checks(self) -> None:
from factory.workflow.definitions import design_workflow

wf = design_workflow()
# Design inherits from build — verify inherited sentinel values
# Design overrides build's strategist post_checks with dual-format sentinels
strat = wf.nodes["strategist"]
assert isinstance(strat, AgentNode)
assert len(strat.post_checks) > 0
assert "### Phase 1" in strat.post_checks[0].must_contain
assert "### Architecture" in strat.post_checks[0].must_contain
assert "### Hypotheses" in strat.post_checks[0].must_contain

builder = wf.nodes["builder"]
assert isinstance(builder, AgentNode)
Expand Down
Loading