fix: SyntaxError in init_user_intent FnNode python3 -c one-liner - #1396
Draft
akashgit wants to merge 9 commits into
Draft
fix: SyntaxError in init_user_intent FnNode python3 -c one-liner#1396akashgit wants to merge 9 commits into
akashgit wants to merge 9 commits into
Conversation
Adds the design-v2 workflow as a contributed workflow with dynamic research/strategy/QA directors that scale agent count at inference time based on project complexity, replacing the static fork/join patterns. - Research Director: decides N research directions dynamically (3-7) - Strategy Director: spawns M strategy perspectives (2-5) - QA Director: creates K tailored adversarial test approaches (2-5) - User Intent Ledger: tracks idea + feedback throughout the session - Design Doc: rewrites strategy into human-readable design document - Synthesize QA: merges adversarial reports with confidence scoring 29 nodes, 32 edges. 63 tests covering graph structure, node properties, edge wiring, post checks, and removed-node assertions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…port - Extract all 7 prompt template constants from workflow.py into prompts.py - Remove unused `glob` import from synthesize_qa inline Python (Path.glob used instead) - Add comment on ADVERSARIAL_PROMPT noting it's used by QA Director when spawning testers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The CLI mode validation only checked CEO_MODES and project-local workflows, ignoring builtin registry entries like design-v2. Two fixes: 1. Add "design-v2" to CEO_MODES in _helpers.py 2. Change fallback validation from project-only to all workflow registry entries, so any registered workflow (builtin, contributed, project) is automatically valid 3. Add "design-v2" alongside "design" in all mode routing checks so it supports --focus, --auto-approve, --from-plan, --just-plan Closes #1392 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
design-v2 is a builtin workflow discovered by WorkflowRegistry.discover() and passes the fallback check in _ceo_helpers.py without needing an explicit CEO_MODES entry. The hardcoded entry was redundant. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…2 modes When --auto-approve is passed, the CEO now receives instructions to act as the user at approval gates — reviewing plans against user-intent.md and making PROCEED/feedback decisions instead of waiting for human input. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add design-v2 to mode checks in run.py (auto_approve, focus, skip_improve) - Fix init_user_intent FOCUS env var: read from FACTORY_IDEA env, backlog.md fallback, skip if user-intent.md already exists - Fix single-quote injection in init_user_intent and synthesize_qa by passing project_path via sys.argv instead of string interpolation - Update error messages in _ceo_helpers.py to mention design-v2 - Remove dead ADVERSARIAL_PROMPT constant, fold output format into QA_DIRECTOR_PROMPT Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The command used compound if/else blocks after semicolons in a python3 -c one-liner, which Python does not allow. Rewritten using ternary expressions and or-chains: early exit via (sys.exit(0) if cond else None), idea fallback via env or backlog or default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sentrux Quality ReportAbsoluteDiff (vs base branch) |
Add PHASE 3 (CODE REVIEW) to QA_DIRECTOR_PROMPT in design_v2. The code review runs after all adversarial testers complete and is mandatory regardless of K or adversarial results. Critical/high-severity findings are flagged as blocking in the QA summary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tially The QA Director's Phase 2 now spawns K adversarial testers + 1 code reviewer all in parallel (backgrounded with &, then wait). Previously the code review was a separate Phase 3 that ran after testers completed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
init_user_intentFnNode command infactory/workflow/contributed/design_v2/workflow.pyto eliminate compoundif/elseblocks that causeSyntaxErrorwhen used after semicolons in apython3 -cone-liner(sys.exit(0) if condition else None)or-chain:env_var or backlog_line or default