Skip to content

fix: eliminate no-op knob mutations #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdabaa merged 1 commit into from
Aug 31, 2026
Merged

fix: eliminate no-op knob mutations #1414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions factory/outer_loop/mutations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,8 +724,16 @@ def mutate_knob(
new_val = float(new_val)
except ValueError:
pass
else:
knob_name = random.choice(knob_names)
# Skip no-op: guided value same as current
if str(new_val) == str(old_val):
new_val = None
guided_knob = None
if not guided_knob:
# Exclude synthetic _prompt_* knobs (handled by PROMPT_MUTATE)
real_knobs = [k for k in knob_names if not k.startswith("_prompt_")]
if not real_knobs:
return None
knob_name = random.choice(real_knobs)
old_val = wf.knob_values[knob_name]
bounds = wf.knob_bounds.get(knob_name, [])
new_val = None
Expand Down
Loading