deleting original zip file and adding mime type.#1
Open
guillaume-kuhmel wants to merge 1 commit intoakbng:mainfrom
Open
deleting original zip file and adding mime type.#1guillaume-kuhmel wants to merge 1 commit intoakbng:mainfrom
guillaume-kuhmel wants to merge 1 commit intoakbng:mainfrom
Conversation
akbng
approved these changes
Jun 15, 2022
Owner
akbng
left a comment
akbng
left a comment
There was a problem hiding this comment.
Looks good! I've tested it & it works 👍
akbng
requested changes
Jun 15, 2022
Owner
akbng
left a comment
akbng
left a comment
There was a problem hiding this comment.
I see you're not using UUID, please revert the code on line 36
I've kept it so that there's no conflict between 2 different files with the same name. (or they have to enable versioning on the s3 itself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding code for deleting the zip file after uploading.
Adding code to keep the unziped file mime-type.