Repository navigation
Darkroom marks and a preferred size for test sheets - #44
Merged
Merged
Conversation
A black guide line round the image and registration marks (a crosshair target on each side, corner crop marks), each optional. On negatives they sit in the safe edge in black ink: visible under a red safelight, where red and orange negatives all but vanish, and blocking UV like the safe edge so they never print. Prints get them in a 0.25 in white border. Saved setups remember them; the blocking test and process charts offer them too. The blocking test and process chart page can be enlarged or shrunk to fit within W x H (turned to match, never past the page's margins); remembered as chart_size. Stacked charts now sit 0.1 in apart instead of 0.3 in. CLI: --guide/--registration on negative and target; target --size WxH. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Darkroom marks
Red and orange negatives all but vanish under a red safelight. Two optional checkboxes add black marks that show there:
On negatives they're in black ink in the safe edge, so they block UV like the safe edge and don't print (checked against the simulated carbon print). On inkjet prints they go in a 0.25 in white border, which counts towards the print size. They're available in the Print and Negative tabs (a new "Darkroom marks" section), saved in negative setups, and offered in the blocking test and the process chart wizard. CLI:
--guide,--registrationonnegativeandtarget --kind blocking|chart.Preferred size for test sheets
The blocking test and process chart page can be enlarged or shrunk to fit within W x H. The box turns to match the sheet, the safe edge is included, and the sheet never goes past the page's margins (which don't turn). Patches keep their shape, so scans read as before; I checked this with simulated round trips. The size is remembered (
chart_size) and shared by both wizards, and a process run keeps it inrun.json. CLI:target --size WxH.Tighter stacked charts
The gap between stacked process charts is now 0.1 in (was 0.3 in).
Parity and tests
openquad/marks.py↔Marks.swift; scale helpers in both languages; vectors for masks, marked negatives, print marks, scaled and marked sheets, scales and sessions.tests/test_marks.py, process-run size and marks tests, the app'sMarksTests. Swift core 67 and app 31 tests pass; the pytest suite passes in the hook.🤖 Generated with Claude Code