Skip to content

DeepSeek V4.1: the precision and Engram reference work, combined on the 1.1.2 family line (#1052 + #1051) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akol1 wants to merge 7 commits into
base: pr-dsv41-bc-family-11
Choose a base branch
from
Open

DeepSeek V4.1: the precision and Engram reference work, combined on the 1.1.2 family line (#1052 + #1051) #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0820342
DeepSeek V4.1: the FP32 and FP64 oracles run side by side
akol1 Oct 19, 2026
b25c4a8
DeepSeek V4.1 reference: the FP64 narrowing keeps NaN, and the FP32 o…
akol1 Oct 19, 2026
dd8ce6d
DeepSeek V4.1 reference: fp64 tests for the Engram hash, gather and gate
akol1 Oct 19, 2026
9b440f9
DeepSeek V4.1 reference: hold the Engram gate to the registered kerne…
akol1 Oct 19, 2026
b800c72
DeepSeek V4.1 carry: the Engram export names the relocated module
akol1 Oct 19, 2026
4023e8d
DeepSeek V4.1 carry: the reference check takes the contract module by…
akol1 Oct 20, 2026
6263918
DeepSeek V4.1 reference: the FP32 sign packing matches the consumer w…
akol1 Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions zig/build/deepseek_v41.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ pub fn checks(
.imports = &.{
.{ .name = "tensorfold", .module = engine },
.{ .name = "metal", .module = metal },
.{ .name = "contract", .module = @import("kernel_contract.zig").module(b, target, optimize) },
},
}),
.filters = &.{"tests.deepseek_v41_reference."},
Expand Down
3 changes: 3 additions & 0 deletions zig/deepseek_v41_reference_checks.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,8 @@ test {
_ = @import("tests/deepseek_v41_reference/projection.zig");
_ = @import("tests/deepseek_v41_reference/math.zig");
_ = @import("tests/deepseek_v41_reference/attention_math.zig");
_ = @import("tests/deepseek_v41_reference/engram_math.zig");
_ = @import("tests/deepseek_v41_reference/qualify.zig");
_ = @import("tests/deepseek_v41_reference/precision.zig");
_ = @import("tests/deepseek_v41_reference/operator_engram_fp64.zig");
}
34 changes: 30 additions & 4 deletions zig/deepseek_v41_run.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const load = tf.deepseek_v41_load;
const weights = tf.deepseek_v41_weights;
const process_memory = @import("src/server/process_memory.zig");
const oracle = @import("tests/deepseek_v41_reference/qualify.zig");
const precision = @import("tests/deepseek_v41_reference/precision.zig");
const profile = @import("tests/deepseek_v41_reference/profile.zig");
const trace = @import("tests/deepseek_v41_reference/trace.zig");
const operators = @import("tests/deepseek_v41_reference/operators.zig");
Expand All @@ -21,6 +22,7 @@ fn usage(code: u8) noreturn {
" tf-dsv41-run teacher MODEL TABLES IDS_JSON OUT_DIR [CHUNK]\n" ++
" tf-dsv41-run seams MODEL TABLES IDS_JSON OUT_DIR\n" ++
" tf-dsv41-run oracle MODEL TABLES IDS_JSON OUT_DIR\n" ++
" tf-dsv41-run oracle-precision MODEL TABLES IDS_JSON OUT_DIR\n" ++
" tf-dsv41-run profile MODEL TABLES IDS_JSON OUT_DIR\n" ++
" tf-dsv41-run trace MODEL TABLES IDS_JSON OUT_DIR\n" ++
" tf-dsv41-run operators MODEL TABLES OUT_DIR\n" ++
Expand All @@ -30,7 +32,7 @@ fn usage(code: u8) noreturn {
" tf-dsv41-run moe-sameinput MODEL TABLES TRACE_GPU_BIN OUT_DIR [LAYER]\n" ++
" tf-dsv41-run generate MODEL TABLES IDS_JSON OUT_DIR [TOKENS]\n" ++
"IDS_JSON: nonempty JSON array of token IDs below 129280.\n" ++
"Limits: oracle/trace 16 IDs; profile 256 IDs; teacher/seams 4096 IDs.\n" ++
"Limits: oracle/oracle-precision/trace 16 IDs; profile 256 IDs; teacher/seams 4096 IDs.\n" ++
"History: TOKEN below 4096; retained normalized prefix at most 256 MiB.\n" ++
"Local diagnostics do not qualify the model. Oracle retains the independent 1% NRMS gate.\n", .{});
std.process.exit(code);
Expand All @@ -46,10 +48,19 @@ fn validArguments(args: []const [:0]const u8) bool {
if (std.mem.eql(u8, mode, "attention-history-sameinput")) return args.len == 8;
for ([_][]const u8{ "teacher", "generate", "attention-sameinput", "hc-sameinput", "moe-sameinput" }) |name|
if (std.mem.eql(u8, mode, name)) return args.len == 6 or args.len == 7;
for ([_][]const u8{ "seams", "oracle", "profile", "trace" }) |name|
for ([_][]const u8{ "seams", "oracle", "oracle-precision", "profile", "trace" }) |name|
if (std.mem.eql(u8, mode, name)) return args.len == 6;
return false;
}
test "oracle-precision takes exactly the five mode arguments" {
const six = [_][:0]const u8{ "tf-dsv41-run", "oracle-precision", "model", "tables", "ids.json", "out" };
const five = [_][:0]const u8{ "tf-dsv41-run", "oracle-precision", "model", "tables", "ids.json" };
const seven = [_][:0]const u8{ "tf-dsv41-run", "oracle-precision", "model", "tables", "ids.json", "out", "16" };
try std.testing.expect(validArguments(&six));
try std.testing.expect(!validArguments(&five));
try std.testing.expect(!validArguments(&seven));
}

fn argmax(row: []const f32) !u32 {
var best: u32 = 0;
if (row.len == 0) return error.EmptyLogits;
Expand Down Expand Up @@ -144,18 +155,19 @@ pub fn main(init: std.process.Init) !void {
const is_attention_history = std.mem.eql(u8, mode, "attention-history-sameinput");
const is_hc = std.mem.eql(u8, mode, "hc-sameinput");
const is_moe = std.mem.eql(u8, mode, "moe-sameinput");
const max_ids: usize = if (std.mem.eql(u8, mode, "oracle") or std.mem.eql(u8, mode, "trace")) 16 else if (std.mem.eql(u8, mode, "profile")) ds.prefill_step else if (std.mem.eql(u8, mode, "teacher") or std.mem.eql(u8, mode, "seams")) 4096 else 1048576;
const max_ids: usize = if (std.mem.eql(u8, mode, "oracle") or std.mem.eql(u8, mode, "oracle-precision") or std.mem.eql(u8, mode, "trace")) 16 else if (std.mem.eql(u8, mode, "profile")) ds.prefill_step else if (std.mem.eql(u8, mode, "teacher") or std.mem.eql(u8, mode, "seams")) 4096 else 1048576;
const input = if (is_operators or is_attention or is_attention_history or is_hc or is_moe) &.{} else try std.Io.Dir.cwd().readFileAlloc(io, args[4], arena, .limited(max_ids * 12 + 2));
const ids: []const u32 = if (is_operators or is_attention or is_attention_history or is_hc or is_moe) &.{} else try std.json.parseFromSliceLeaky([]const u32, arena, input, .{});
if (!is_operators and !is_attention and !is_attention_history and !is_hc and !is_moe and (ids.len == 0 or ids.len > 1048576)) return error.InvalidPrompt;
if (ids.len > max_ids) return error.InvalidPrompt;
for (ids) |id| if (id >= 129280) return error.InvalidToken;
const is_oracle = std.mem.eql(u8, mode, "oracle");
const is_precision = std.mem.eql(u8, mode, "oracle-precision");
const is_trace = std.mem.eql(u8, mode, "trace");
const dir = args[if (is_operators) @as(usize, 4) else 5];
try std.Io.Dir.cwd().createDirPath(io, dir);
const map = try std.fs.path.join(arena, &.{ args[2], "engram-token-map.bin" });
const map_blob = if (is_oracle or is_trace)
const map_blob = if (is_oracle or is_trace or is_precision)
try std.Io.Dir.cwd().readFileAlloc(io, map, arena, .limited(2 << 20))
else
&.{};
Expand Down Expand Up @@ -206,6 +218,7 @@ fn execute(a: std.mem.Allocator, io: std.Io, model: *ds.Model, args: []const [:0
const is_hc = std.mem.eql(u8, mode, "hc-sameinput");
const is_moe = std.mem.eql(u8, mode, "moe-sameinput");
const is_oracle = std.mem.eql(u8, mode, "oracle");
const is_precision = std.mem.eql(u8, mode, "oracle-precision");
const is_profile = std.mem.eql(u8, mode, "profile");
const is_trace = std.mem.eql(u8, mode, "trace");
const is_teacher = std.mem.eql(u8, mode, "teacher");
Expand All @@ -223,6 +236,19 @@ fn execute(a: std.mem.Allocator, io: std.Io, model: *ds.Model, args: []const [:0
} else if (is_oracle) {
try operators.run(a, io, model, dir);
_ = try oracle.run(a, io, model, ids, map_blob, dir);
} else if (is_precision) {
const run = try precision.run(a, model, ids, map_blob);
defer run.logits.deinit(a);
// Capture execution before the diagnostics and artifacts below, not the reads they cause.
execution_after.* = try counters();
for (run.logits.argmax, 0..) |pair, i|
std.debug.print("precision token {d}/{d}: fp32 argmax={d}, fp64 argmax={d}\n", .{ i + 1, run.logits.argmax.len, pair[0], pair[1] });
const json = try std.json.Stringify.valueAlloc(a, run.result, .{});
defer a.free(json);
std.debug.print("{s}\n", .{json});
try write(io, a, dir, "precision-fp32-vs-fp64.json", json);
try write(io, a, dir, "reference-fp32-logits.f32", std.mem.sliceAsBytes(run.logits.fp32));
try write(io, a, dir, "reference-fp64-logits.f64", std.mem.sliceAsBytes(run.logits.fp64));
} else if (is_profile) {
try profile.run(a, io, model, ids, dir);
} else if (is_trace) {
Expand Down
1 change: 1 addition & 0 deletions zig/src/tensorfold.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ pub const deepseek_v41_profiler = @import("families/deepseek_v41/metal/profiler.
pub const gpu_counters = @import("core/gpu_counters.zig");
pub const expert_groups = @import("core/expert_groups.zig");
pub const deepseek_v41_engram_hash = @import("families/deepseek_v41/engram_hash.zig");
pub const deepseek_v41_engram = @import("families/deepseek_v41/metal/engram.zig");
pub const exl3_format = @import("core/exl3_format.zig");
pub const exl3_projection = @import("core/exl3_projection.zig");
pub const exlr8 = @import("core/exlr8.zig");
Expand Down
Loading
Loading