chore: add test environment to ruleset policy - #1
Merged
Merged
Conversation
Adds 'test' to environments, declared after 'dev' so task-sync rank follows the real pipeline order (dev -> test). Picks up the existing environmentStatuses mapping of test -> 'QA'. Landing this before running the sync keeps the committed policy and the live rulesets in agreement; applying first would leave the repo's policy saying dev-only while the rulesets covered test. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
testtoenvironmentsin the repo's committed ruleset policy.Declared after
devso task-sync rank follows the real pipeline order, picking up the existingenvironmentStatusesmapping:dev→in progresstest→QAWhy this lands before the sync run
The sync CLI writes an added environment to
.github/ruleset-config.jsonwithwriteFileSync— it edits the file locally and never commits it. Applying first would leave the committed policy saying dev-only while the live rulesets coveredtest, and the next--reporun would read the committed file and plan[no longer covers test], stripping the protection back off.What the sync will do once this is merged
UPDATEPull Request Compulsion →~DEFAULT_BRANCH,dev,testUPDATEEnforce Branch Nomenclature → excluded refs 12 → 13CREATEthetestbranch frommainUPDATEclickup-sync.ymlandpr-scope-check.ymlPR-SCOPE-CHECKstays scoped todevonly — thetestprofile is{}, so it carries no status-check requirement🤖 Generated with Claude Code