Skip to content

Add leaderboard to initial welcome screen #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akshayravikumar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add leaderboard to initial welcome screen #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions public/assets/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ function showIntro() {

displayLaTeXInBody();
$("#container").show();

loadTopScoresThisMonth();
}

function endGame() {
Expand Down Expand Up @@ -344,6 +346,46 @@ async function loadLeaderboard(timeRange) {
}
}

async function loadTopScoresThisMonth() {

@ellipsis-dev ellipsis-dev Bot Jan 23, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the existing loadLeaderboard function which already supports monthly filtering via timeRange='month'. Consider extending the existing function with parameters for limit and target element instead of creating a new one.

const leaderboardSection = $("#leaderboard-section");
leaderboardSection.empty();

try {
let query = db.collection('leaderboard');

// Add time constraints for the current month
const now = new Date();
const startOfMonth = new Date(now.getFullYear(), now.getMonth(), 1);
query = query.where('timestamp', '>=', startOfMonth);

const snapshot = await query.orderBy('score', 'desc').limit(5).get();

if (snapshot.empty) {
leaderboardSection.append('<p>No scores yet!</p>');
return;
}

leaderboardSection.append('<h2>Top Scores This Month</h2>');

let rank = 1;
snapshot.forEach((doc) => {
const data = doc.data();
const scoreEntry = `
<div class="leaderboard-entry" style="margin: 5px 0;">
<span class="rank">#${rank}</span>
<span class="name">${escapeHtml(data.name)}</span>
<span class="score">${data.score} points</span>
</div>
`;
leaderboardSection.append(scoreEntry);
rank++;
});
} catch (error) {
console.error("Error loading top scores this month:", error);
leaderboardSection.append('<p>Error loading top scores</p>');
}
}

// Start by showing the intro.
$(document).ready(function() {
// Handlers
Expand Down