Skip to content

Port Spotty to Rune with integrated Rust playback - #627

Open
aladh wants to merge 15 commits into
mainfrom
codex/spotty-rune-port
Open

aladh wants to merge 15 commits into
mainfrom
codex/spotty-rune-port

Conversation

@aladh

@aladh aladh commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

What changes

  • Build the macOS app with Rune. Port the README playlist scene and the catalog, playback controls, Queue, and Spotify Connect workflows.
  • Compile playback into the Rust app. Retire the standalone playback crate, C adapter, and XCFramework production workflow. Serialize blocking playback commands on the dedicated command thread.
  • Preserve account retirement through restarts, recheck playlist mutation authority, preserve visible queue-add order, and cover delayed startup links and artwork retries.
  • Switch packaging, release staging, acceptance, and developer entry points to Rune. Give Rune its own update channel and release-note filenames. Keep the earlier Swift release sources and fixtures available for historical verification.

Acceptance declarations

  • Product contracts affected — scope and visual fidelity, navigation and startup, playlist edits, queue ordering, playback and Connect, and account privacy.
  • Repository rules and records — the build and review entry points target Rune. ADR 011 records internal playback ownership. Historical Swift release records and their update channel remain available.
  • Representative scenario IDs run — rune.integrated, playback.transport, and rune.reference passed on clean source 5c2b1c5a2bd4ff81b04c772068b4f04b6ce9c66f.
  • Scenario IDs added or changed — the Rune manifest adds those three IDs and supersedes the Swift-era harness for active CI.
  • Unverified acceptance scope — signed Apple Silicon execution, VoiceOver and macOS input behavior, physical output routing, Sparkle delivery, and live Spotify playback or mutations require native or account-specific acceptance. Local evidence uses the isolated Linux synthetic fixture.

Verification

201 regular Rust tests passed and four retained transport traces passed their independent gate. The Linux executable exports no Spotty playback C symbols. The synthetic reference rendered without layout warnings. Astra independently reviewed the Rust playback boundary and the account, queue, and reload regressions. Remaining audit items include streaming credential persistence, audio-device loss, catalog access refusals, and authorized live Spotify behavior.

Screenshots and interaction recordings

Main README reference Rune capture from this PR
Main README playlist reference Rune playlist reference

Playlist, Queue, and Connect

Rune replay of playlist sorting, filtering, Queue, and Connect

Full MP4 · Input replay · Filtered playlist · Queue · Recently played · Connect

Search and back navigation

Search results Opened playlist Back restores the query
Search results Opened playlist Restored search

Full MP4 · Input replay

Both recordings replay timestamped input against synthetic data. They were captured at the original port commit. The clean-head reference PNG and accessibility tree match the original Rune captures byte for byte after the review fixes. The README comparison shows layout and styling at the reference viewport. The recordings cover selected interactions at 1280×800. Native macOS behavior and live audio require separate checks.

Back and Forward across two searches

The recording from 3dfd957 shows the app restoring Moonlit when going back and Neon when going forward. New MP4 · Input replay · Back screenshot · Forward screenshot

Reproducible evidence

Review follow-up

  • Restored the required Source policies check and added source routing and build-wrapper fixtures. The macOS aggregate requires the source, Linux, and Apple Silicon jobs. Linux, Apple Silicon and signed release-bundle verification passed on 5c2b1c5. Source checks and release-bundle run · Verified Apple Silicon bundle notices for 5c2b1c5 · CI acceptance for 5c2b1c5 · Nine rule groups and 16 routing tests

  • Tested reconnect context-to-track fallback, queue replacement order, catalog page reservations, retirement fencing across processes, search history, expanded album selection, and update feed validation. Astra independently passed all 28 focused live tests after reviewing the catalog and session locks. Integrated test log

  • Both required OpenCode reviews on 5c2b1c5 completed input collection and reported that OpenCode Zen had reached its free usage limit. Source policies and macOS checks passed on the same commit. Cubic approved the same commit, and GitHub reports that the reviewer can push to the repository. Approval Documentation review · Thermos review · Review configuration

  • macOS packaging generates and verifies notices from the locked native build graph. The Apple Silicon bundle on 5c2b1c5 contains 390 dependency records and 270 license and notice files, all independently hash-verified. Two Linux cross-target runs on 085ba4e produced byte-identical output with 393 records and 272 files. The three extra records are Linux host build dependencies. Validation binds the Markdown and every referenced text to the inventory and verifies every recorded input against the source checkout. The AccessKit notices preserve its upstream Apache file and include the full canonical text with the standard appendix. dispatch@0.2.0 retains its upstream MIT declaration and named author alongside a separately labeled canonical MIT reference because the pinned upstream contains no license file. Notice inventory · Verification log

  • Physical device buffering and output recovery during sleep and wake still require native observation. The suspend path retires its software ring and blocks late PCM writes before queuing the librespot pause. The regression test verifies rejection during suspend and admission on restart. The producer preserves the existing bounded playback pacing. Live Spotify access refusals remain unverified. The Swift workflow fixtures run from the pinned historical source and pass all 37 tests. The sign-out sweep intentionally covers all recognized account partitions. Review discussion

  • Recent review fixes preserve device membership after an overtaken Connect snapshot, cancel pending transfers when the owning generation retires, retire obsolete PCM frames in bounded callback work, and preserve large saved-album and artist libraries. Current acceptance proof

  • The final source-policy follow-up checks workflow triggers, read-only acceptance tokens, and both platform dependencies. Six workflow tests and the shared source gate passed. Source policy results

  • The reviewers now read all thread and reply pages and recheck relevant threads by ID before approval. The previous run stopped at one page. The new collector read 103 threads from GitHub, and 45 review-automation tests passed. Previous run · Pagination and approval tests

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

Turn on auto-fix | Re-trigger cubic

Comment thread Rune/configure-updates.py Resolved
Comment thread Rune/src/playback/transport.rs Resolved
Comment thread .github/workflows/ci.yml Resolved
Comment thread docs/development/signing.md Resolved
Comment thread README.md Resolved
Comment thread docs/development/verification.md Resolved
Comment thread Rune/src/playback/tests.rs Resolved
Comment thread Scripts/validate-app.sh Resolved
Comment thread Rune/package-macos.sh Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 143 files

Confidence score: 3/5

  • In Rune/src/playback/proxy_sink.rs, clear_buffer() can return while an old frame is still loaded, so stale audio may play after disconnect or during a rebuild. Wait for the renderer to acknowledge the clear before returning.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Rune/src/playback/proxy_sink.rs">

<violation number="1" location="Rune/src/playback/proxy_sink.rs:20">
P2: `clear_buffer()` returns before the cpal renderer has acknowledged the clear, so an already-loaded old frame can still play after disconnect or during a rebuild. Add an acknowledgement/barrier (or otherwise synchronously drain/stop the renderer) before treating this command as flushed.</violation>
</file>

Requires human review: Auto-approval blocked because this review re-detected 22 unresolved issues already reported by Cubic.

Turn on auto-fix | Re-trigger cubic

Comment thread Rune/src/playback/transport.rs Resolved
Comment thread .github/workflows/ci.yml Resolved
Comment thread Rune/src/live/catalog.rs Resolved
Comment thread docs/product/playback-evidence.md Resolved
Comment thread Rune/src/live/auth/retirement.rs Resolved
Comment thread Rune/src/live/auth/retirement.rs Resolved
Comment thread Rune/src/demo.rs Resolved
Comment thread Rune/src/view/components.rs Resolved
Comment thread Rune/src/demo.rs Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 35 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 62 unresolved issues from previous reviews.

Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/docs-review/opencode.json Resolved
Comment thread Scripts/verify.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 35 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread Rune/src/live/catalog.rs Resolved
Comment thread .github/workflows/agent-review.yml Resolved
Comment thread .github/workflows/agent-review.yml Resolved
Comment thread .github/workflows/agent-review.yml Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 28 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread Scripts/workflow_policy.rb Resolved
Comment thread Scripts/workflow_policy.rb Resolved
Comment thread Scripts/test_rune_workflow_policy.py Resolved
Comment thread docs/development/verification.md Resolved
Comment thread Scripts/ci_workflow_fixtures.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files (changes from recent commits).

Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.

Turn on auto-fix | Re-trigger cubic

Comment thread docs/development/verification.md Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/agent-review/publish.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 21 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread Scripts/generate-rune-notices.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 4 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Turn on auto-fix | Re-trigger cubic

cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Nov 18, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Turn on auto-fix | Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant