Fix dtls hash creation and allow empty tlsa_ttl#5
Open
pkolmann wants to merge 1 commit intoalainwolf:mainfrom
Open
Fix dtls hash creation and allow empty tlsa_ttl#5pkolmann wants to merge 1 commit intoalainwolf:mainfrom
pkolmann wants to merge 1 commit intoalainwolf:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @alainwolf
thanks for this script. I started using it in one of my domains and found that it failed all DANE online checks.
After checking https://github.com/cpcloudnl/dane-smtp#generate-the-sha2-256-hash-based-on-the-spki I found that you strip '\0' from the DER encoded cert. This alters the certificate and therefore also the hash.
I asked chatgpt to help me to improve your script.
Also I didn't specify tlsa_ttl as specified in the top and dnsutil failed to process.
I have updated my zone with this new script and now DANE checks are successful:
Does your script work for you? Do I have some bug in by setup?
thanks Philipp