Finished up work started in PR (#263) auto incrementing the port if it is already in use#278
Open
Finished up work started in PR (#263) auto incrementing the port if it is already in use#278
Conversation
alallier
changed the title
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 131 144 +13
=========================================
+ Hits 131 144 +13
Continue to review full report at Codecov.
|
Closed
alallier
commented
Nov 19, 2020
|
Hey, this is awesome to see. 👍 Thanks for tagging me. Hope I didn’t give you too much trouble! 🤞🏼 |
Owner
Author
|
@al5ina5 no problem at all you got the ball rolling. You should be a first time reload contributor soon when this gets merged! |
Owner
Author
|
Per #256 we should still reject if the auto increment option is turned off and there is a port conflict |
alallier
force-pushed
the
tweakPortIncrement
branch
from
9196aad to
090bc5c
Compare
… the port if it is already in use. This commit adds the following to the existing work: * Added new tests * Added the port to reload's return object so the calling program knows what port reload ending up using if the port auto increments * Added autoIncrementPort optional param to realod to turn off auto port incrementing. Default `true` * Tweaked the code to work correctly, like handling the promise return correctly * Small tweaks to how the generated client side code replace works. Removed a branch that wasn't hitting in coverage and made it more readable * Updated README with API changes
alallier
force-pushed
the
tweakPortIncrement
branch
from
090bc5c to
ff58c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished up work started by @al5ina5 in PR (#263) auto incrementing the port if it is already in use
This adds the following ontop of the work already started by @al5ina5:
trueCloses #256
Branched off work from PR #263