Skip to content

chore: remove stale Makefile release/push targets (reference deleted VERSION file, bypass CI) #77

Description

@alanbem

Problem

Two Makefile targets predate the current release process and are now broken or dangerous:

  • make release runs cat VERSION — the file no longer exists (git tags are the source of truth per CLAUDE.md), so the target fails immediately; if it worked, it would also commit a VERSION file back into the repo
  • make push pushes alanbem/dclaude:latest directly to Docker Hub and runs npm publish from the working tree, bypassing the CI release flow (SHA-pinned actions, multi-arch build, OIDC npm publishing)

Fix

Delete both targets (and the push/release lines from make help). The documented release path is gh release create vX.Y.Z + CI.


Found during a full-project code review.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions