Skip to content

fix(metrics): CPU usage shown inverted on Linux (~99% when idle) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flavioduque wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(metrics): CPU usage shown inverted on Linux (~99% when idle) #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions src/app/api/system/metrics/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async function getCpuUsage(): Promise<{ usage: number; cores: number }> {
try {
// Cross-platform CPU usage calculation
if (process.platform === 'linux' || process.platform === 'darwin') {
const { stdout } = await execAsync("top -l 1 -n 0 | grep 'CPU usage' || mpstat 1 1 | tail -1 | awk '{print 100 - $NF}'")
const { stdout } = await execAsync("top -l 1 -n 0 | grep 'CPU usage' || mpstat 1 1 | tail -1 | awk '{print $NF}'")

// macOS format: CPU usage: X% user, Y% sys, Z% idle
const match = stdout.match(/(\d+\.?\d*)% idle/) || stdout.match(/^(\d+\.?\d*)/)
Expand All @@ -47,27 +47,31 @@ async function getCpuUsage(): Promise<{ usage: number; cores: number }> {
}
}

// Fallback: calculate from os module (less accurate but always works)
const cpus = os.cpus()
let totalIdle = 0
let totalTick = 0
} catch {
// command failed: use the os module below instead of inventing a value
}

for (const cpu of cpus) {
for (const type in cpu.times) {
totalTick += cpu.times[type as keyof typeof cpu.times]
}
totalIdle += cpu.times.idle
}
return cpuUsageFromOs(cores)
}

const idle = totalIdle / cpus.length
const total = totalTick / cpus.length
const usage = Math.round(100 - (idle / total) * 100)
// Fallback: calculate from os module (average since boot, less accurate but real)
function cpuUsageFromOs(cores: number): { usage: number; cores: number } {
const cpus = os.cpus()
let totalIdle = 0
let totalTick = 0

return { usage: Math.max(0, Math.min(100, usage)), cores }
} catch {
// Return a simulated value if we can't get real data
return { usage: Math.floor(Math.random() * 30) + 10, cores }
for (const cpu of cpus) {
for (const type in cpu.times) {
totalTick += cpu.times[type as keyof typeof cpu.times]
}
totalIdle += cpu.times.idle
}

const idle = totalIdle / cpus.length
const total = totalTick / cpus.length
const usage = Math.round(100 - (idle / total) * 100)

return { usage: Math.max(0, Math.min(100, usage)), cores }
}

// Get memory usage
Expand Down